Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connector Builder] Set default value for end_datetime #21995

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

lmossman
Copy link
Contributor

What

Resolves #21572

How

Sets the default value of end_datetime to {{ now_utc() }} using the existing BuilderOneOf default value mechanism.

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 27, 2023
@flash1293
Copy link
Contributor

flash1293 commented Jan 30, 2023

This behaves as discussed but I'm just wondering... this only works if the user also sets the date format on the slicer correctly which is what is used for the end datetime, right? Should we set it to the format now_utc() generates as well?
Screenshot 2023-01-30 at 17 52 34

Otherwise it's actually quite hard to figure out what to do about it - I had to look through existing manifests to figure out that it's %Y-%m-%d %H:%M:%S.%f+00:00

If you don't set it, the config won't work

@lmossman
Copy link
Contributor Author

lmossman commented Jan 31, 2023

@flash1293 I think your suggestion makes sense; setting the format will help people who don't want to change anything here, and will also give an example of a format that can be used. Added.

@lmossman lmossman requested review from flash1293 and removed request for flash1293 February 1, 2023 02:06
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Connector Builder] Set default values for end datetime
3 participants