🎉 Source Bing Ads - added high test_strictness_level #22103

midavadim · 2023-01-30T22:03:25Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2023-01-30T22:03:31Z

All committers have signed the CLA.

midavadim · 2023-01-30T22:04:53Z

/test connector=connectors/source-bing-ads

midavadim · 2023-01-30T22:55:27Z

/test connector=connectors/source-bing-ads

lazebnyi · 2023-01-31T01:08:48Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4049720920
❌ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4049720920
🐛

Build Failed

Test summary info:

Could not find result summary

midavadim · 2023-01-31T13:15:20Z

/test connector=connectors/source-bing-ads

midavadim · 2023-01-31T14:25:13Z

/test connector=connectors/source-bing-ads

…evel # Conflicts: # airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml

midavadim · 2023-01-31T17:05:55Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4056513264
❌ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4056513264
🐛

Build Failed

Test summary info:

Could not find result summary

midavadim · 2023-02-01T12:32:07Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4064376447
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4064376447
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/source.py       260     10    96%
source_bing_ads/cache.py         18      1    94%
source_bing_ads/reports.py      133     17    87%
source_bing_ads/client.py        93     21    77%
-------------------------------------------------
TOTAL                           506     49    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: SAT doesn't support complex nested states used in incremental report streams
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 33 passed, 3 skipped in 567.09s (0:09:27) ===================

evantahler

I'd like to learn more about why the incremental tests aren't working

airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml

airbyte-integrations/connectors/source-bing-ads/integration_tests/expected_records.txt

evantahler

Please note https://github.com/airbytehq/airbyte/actions/runs/4064358090/jobs/6997691978 - AllowedHosts need to be added for this connector

midavadim · 2023-02-02T14:46:12Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4075628366
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4075628366
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/source.py       260     10    96%
source_bing_ads/cache.py         18      1    94%
source_bing_ads/reports.py      133     17    87%
source_bing_ads/client.py        93     21    77%
-------------------------------------------------
TOTAL                           506     49    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: SAT doesn't support complex nested states used in incremental report streams
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 33 passed, 3 skipped in 559.01s (0:09:19) ===================

evantahler · 2023-02-02T17:20:49Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+  allowedHosts:
+    hosts:
+      - bingads.microsoft.com
+      - login.microsoftonline.com
+      - login.live.com
+      - login.windows-ppe.net
+      - ads.microsoft.com
+      - api.ads.microsoft.com


👍 Allowed hosts!

…evel

lazebnyi · 2023-02-02T22:20:47Z

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4079172900
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/4079172900
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_bing_ads/__init__.py       2      0   100%
source_bing_ads/source.py       260     10    96%
source_bing_ads/cache.py         18      1    94%
source_bing_ads/reports.py      133     17    87%
source_bing_ads/client.py        93     21    77%
-------------------------------------------------
TOTAL                           506     49    90%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: SAT doesn't support complex nested states used in incremental report streams
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 33 passed, 3 skipped in 571.72s (0:09:31) ===================

github-actions · 2023-02-02T22:29:17Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.52%	❌

added high test_strictness_level

d5e4bf2

octavia-squidington-iv added connectors/source/bing-ads area/connectors Connector related issues labels Jan 30, 2023

midavadim linked an issue Jan 30, 2023 that may be closed by this pull request

Source Bing Ads: enable high test strictness level in SAT #19037

Closed

midavadim requested a review from lazebnyi January 30, 2023 22:06

lazebnyi assigned lazebnyi and midavadim Jan 31, 2023

Merge branch 'master' into midavadim/19037-bing-ads-high-strictness-l…

2d13ae9

…evel # Conflicts: # airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml

roman-yermilov-gl approved these changes Jan 31, 2023

View reviewed changes

updated expected records

534610a

midavadim requested a review from evantahler February 1, 2023 13:22

lazebnyi approved these changes Feb 1, 2023

View reviewed changes

evantahler reviewed Feb 1, 2023

View reviewed changes

airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml Show resolved Hide resolved

airbyte-integrations/connectors/source-bing-ads/integration_tests/expected_records.txt Show resolved Hide resolved

midavadim requested a review from evantahler February 1, 2023 22:15

evantahler approved these changes Feb 2, 2023

View reviewed changes

evantahler requested changes Feb 2, 2023

View reviewed changes

added allowedHosts for bing ads

6ce24e0

midavadim temporarily deployed to more-secrets February 2, 2023 14:47 — with GitHub Actions Inactive

midavadim requested a review from evantahler February 2, 2023 17:19

evantahler approved these changes Feb 2, 2023

View reviewed changes

Merge branch 'master' into midavadim/19037-bing-ads-high-strictness-l…

310b66c

…evel

midavadim temporarily deployed to more-secrets February 2, 2023 17:38 — with GitHub Actions Inactive

Merge branch 'master' into midavadim/19037-bing-ads-high-strictness-l…

f3880a8

…evel

lazebnyi temporarily deployed to more-secrets February 2, 2023 22:22 — with GitHub Actions Inactive

midavadim merged commit 285661c into master Feb 6, 2023

midavadim deleted the midavadim/19037-bing-ads-high-strictness-level branch February 6, 2023 20:05

github-actions bot mentioned this pull request Feb 7, 2023

Bump helm chart version reference to 0.43.28 #22489

Closed

This was referenced Feb 8, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22578

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Bing Ads - added high test_strictness_level #22103

🎉 Source Bing Ads - added high test_strictness_level #22103

midavadim commented Jan 30, 2023

CLAassistant commented Jan 30, 2023 •

edited

Loading

midavadim commented Jan 30, 2023

midavadim commented Jan 30, 2023

lazebnyi commented Jan 31, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 31, 2023

midavadim commented Jan 31, 2023

midavadim commented Jan 31, 2023 •

edited by github-actions bot

Loading

midavadim commented Feb 1, 2023 •

edited by github-actions bot

Loading

evantahler left a comment

evantahler left a comment

midavadim commented Feb 2, 2023 •

edited by github-actions bot

Loading

evantahler Feb 2, 2023

lazebnyi commented Feb 2, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 2, 2023

🎉 Source Bing Ads - added high test_strictness_level #22103

🎉 Source Bing Ads - added high test_strictness_level #22103

Conversation

midavadim commented Jan 30, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Jan 30, 2023 • edited Loading

midavadim commented Jan 30, 2023

midavadim commented Jan 30, 2023

lazebnyi commented Jan 31, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Jan 31, 2023

midavadim commented Jan 31, 2023

midavadim commented Jan 31, 2023 • edited by github-actions bot Loading

Build Failed

midavadim commented Feb 1, 2023 • edited by github-actions bot Loading

Build Passed

evantahler left a comment

Choose a reason for hiding this comment

evantahler left a comment

Choose a reason for hiding this comment

midavadim commented Feb 2, 2023 • edited by github-actions bot Loading

Build Passed

evantahler Feb 2, 2023

Choose a reason for hiding this comment

lazebnyi commented Feb 2, 2023 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Feb 2, 2023

Airbyte Code Coverage

CLAassistant commented Jan 30, 2023 •

edited

Loading

lazebnyi commented Jan 31, 2023 •

edited by github-actions bot

Loading

midavadim commented Jan 31, 2023 •

edited by github-actions bot

Loading

midavadim commented Feb 1, 2023 •

edited by github-actions bot

Loading

midavadim commented Feb 2, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Feb 2, 2023 •

edited by github-actions bot

Loading