🪟 🐛 Fix issue with opener window closed #22107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmossman
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Changes LGTM, tested locally and it works as expected.
Though, I think it would be ideal if closing the original Airbyte tab would just cause the OAuth popup to automatically close as well. Is that approach also simple to achieve (I assume not)? If so I would vote to go with that behavior; if not then I think what we have here is fine too.
|
@lmossman I agree this is indeed better. I added this to the PR as well. I'd still leave the other code for safty reasons, to not crash in case that still happens (since closing event handler can be a bit tricky and potentially not called by the browser). |
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes a weird edge-casey issue (that I've seen some users run into), when starting an OAuth flow for a connector and then closing the original Airbyte tab, but keep the OAuth flow popup open and finish it. Currently it will bring you back to the webapp after the flow, and we'll try to call
window.opener.postMessage, butwindow.opener(the original tab) is now closed so we'll crash the popup window also with a "Ooops something went wrong" screen.Changing this, so in case the original tab was closed and you still finish the OAuth flow, we'll just close this, and basically ignore it, since the user aborted setting up the connector by closing that tab.