-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New source: Native Hubspot connector #2215
Merged
Merged
Changes from 38 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
49cb4cb
#2150 Issue: created native connector with schema folder populated
5423d13
#2150 Issue: make format code
10a106b
first version
eugene-kulak e667fd0
fix few issues
eugene-kulak 10af6c9
fix issues
eugene-kulak 2e47519
fix read issue
eugene-kulak a180e71
format
eugene-kulak 21152c6
docs
eugene-kulak 3dc6556
docker tags
eugene-kulak 66b03d0
extend configured catalog for testing
eugene-kulak 2bc9f01
fix source definitions
eugene-kulak 0611ac7
format
eugene-kulak 42f24bb
fix call rate issue, add backoff for retry after
eugene-kulak 4479e02
add general backoff
eugene-kulak dd4e982
write secrets for new connector
eugene-kulak fc57695
drop singer connector registration
eugene-kulak a2ee039
refactor streams, resolve properties in schemas at runtime
eugene-kulak aa766eb
replace deprecated endpoint for company contacts
eugene-kulak 759043e
replace deprecated pipeline endpoint
eugene-kulak 4d6c851
update comments
eugene-kulak bca6024
update docs
eugene-kulak 3b65548
fix typo
eugene-kulak 39f0cf7
fix stream contact lists
eugene-kulak 136190a
fix pagination and forms result fetching
eugene-kulak f861888
fix health_check
eugene-kulak caf1c26
format and update catalog
eugene-kulak 6788be2
revert changes
eugene-kulak e084f46
drop singer based hubspot
eugene-kulak 8b52bc3
fix company contacts substream
eugene-kulak 0e52c9a
move deals to separate test
eugene-kulak 308cbec
fix deals tests
eugene-kulak a1f2b69
remove dynamic fields from records
eugene-kulak a6830f8
move deals to catalog again
eugene-kulak 94c6b75
extend CRMObjectStream with associations
eugene-kulak 36f4124
format
eugene-kulak 3a664eb
update schemas with updated field, change engagement layout
eugene-kulak 37f3acb
fix Campaign stream
eugene-kulak ad6988f
remove custom tests
eugene-kulak e00c32a
remove dependency
eugene-kulak 1312d21
remove oauth
eugene-kulak 0bfabee
Source Hubspot: add incremental streams (#2425)
keu 61c8805
Source Hubspot: best practices (#2537)
keu 2764dd3
Merge remote-tracking branch 'origin/master' into keu/source-hubspot-…
eugene-kulak a35389b
restored configured_catalog.json
eugene-kulak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
...ain/resources/config/STANDARD_SOURCE_DEFINITION/36c891d9-4bd9-43ac-bad2-10e12756272c.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "sourceDefinitionId": "36c891d9-4bd9-43ac-bad2-10e12756272c", | ||
| "name": "Hubspot", | ||
| "dockerRepository": "airbyte/source-hubspot", | ||
| "dockerImageTag": "0.1.0", | ||
| "documentationUrl": "https://https://docs.airbyte.io/integrations/sources/hubspot" | ||
| } |
7 changes: 0 additions & 7 deletions
7
...ain/resources/config/STANDARD_SOURCE_DEFINITION/57eb1576-8f52-463d-beb6-2e107cdf571d.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
airbyte-integrations/connectors/source-hubspot-singer/.dockerignore
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
airbyte-integrations/connectors/source-hubspot-singer/Dockerfile
This file was deleted.
Oops, something went wrong.
24 changes: 0 additions & 24 deletions
24
airbyte-integrations/connectors/source-hubspot-singer/Dockerfile.test
This file was deleted.
Oops, something went wrong.
61 changes: 0 additions & 61 deletions
61
airbyte-integrations/connectors/source-hubspot-singer/README.md
This file was deleted.
Oops, something went wrong.
13 changes: 0 additions & 13 deletions
13
airbyte-integrations/connectors/source-hubspot-singer/build.gradle
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
airbyte-integrations/connectors/source-hubspot-singer/requirements.standard-test.txt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only make the new version available once incremental is complete. We can then also completely remove the old hubspot connector (rather than rename it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my intention was to add a completely new connector, then release it and drop the one that based on singer. But maybe accidentally renamed the old instead, not sure, need to check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important thing is not to have 2 hubspot connectors in Airbyte at the same time. the user only cares about syncing data from hubspot, Singer vs. native is an implementation detail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clear, I have removed the old connector