Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ConfigFileClient to allow an invalid path #22187

Merged
merged 1 commit into from
Feb 1, 2023
Merged

update ConfigFileClient to allow an invalid path #22187

merged 1 commit into from
Feb 1, 2023

Conversation

colesnodgrass
Copy link
Member

What

  • allow ConfigFileClient to accept an invalid path
    • now logs a messages instead of throwing an exception

How

  • check if the files exists before attempting to read it

@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 01:10 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 01:10 — with GitHub Actions Inactive
@davinchia davinchia merged commit d36032f into master Feb 1, 2023
@davinchia davinchia deleted the cole/ff-allow-invalid-path branch February 1, 2023 01:16
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.51% ❌

@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
This was referenced Feb 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colesnodgrass @davinchia