Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Airtable: fix API Key authentication #22224

Merged
merged 8 commits into from
Feb 1, 2023

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Feb 1, 2023

What

Resolving:

How

  • added missing api_key authentication part with new credentials input config structure.

🚨 User Impact 🚨

No impact is expected.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Feb 1, 2023
@tybernstein
Copy link
Contributor

@bazarnov I noticed you unlinked the PR from the two OC issues. Was there a reason why, will this PR still fix those issues?

@bazarnov
Copy link
Collaborator Author

bazarnov commented Feb 1, 2023

@bazarnov I noticed you unlinked the PR from the two OC issues. Was there a reason why, will this PR still fix those issues?

Unlinked to avoid auto-close after the PR is merged into OSS master.

@tybernstein
Copy link
Contributor

That makes sense, I didn't realize that was the behavior, thank you for explaining! Do you know when this will be merged?

@bazarnov
Copy link
Collaborator Author

bazarnov commented Feb 1, 2023

/publish connector=connectors/source-airtable

🕑 Publishing the following connectors:
connectors/source-airtable
https://github.com/airbytehq/airbyte/actions/runs/4067649899


Connector Did it publish? Were definitions generated?
connectors/source-airtable

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov temporarily deployed to more-secrets February 1, 2023 18:56 — with GitHub Actions Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 1, 2023 18:56 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.52%

@bazarnov bazarnov enabled auto-merge (squash) February 1, 2023 19:15
@bazarnov bazarnov temporarily deployed to more-secrets February 1, 2023 19:15 — with GitHub Actions Inactive
@bazarnov bazarnov temporarily deployed to more-secrets February 1, 2023 19:15 — with GitHub Actions Inactive
@bazarnov bazarnov merged commit b0dd975 into master Feb 1, 2023
@bazarnov bazarnov deleted the baz/source-airtable-auth-fix branch February 1, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/airtable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants