Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "remove airbyte-commons-docker" #22237

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Revert "remove airbyte-commons-docker" #22237

merged 1 commit into from
Feb 1, 2023

Conversation

colesnodgrass
Copy link
Member

Reverts #21756

reverting as this causes in an issue in cloud

@colesnodgrass colesnodgrass requested a review from a team as a code owner February 1, 2023 19:48
@octavia-squidington-iii octavia-squidington-iii added area/platform issues related to the platform area/server area/worker Related to worker labels Feb 1, 2023
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 19:49 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 19:49 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Airbyte Code Coverage

File Coverage [78.58%] 🍏
JobErrorReporter.java 100% 🍏
LocalDefinitionsProvider.java 94.85% 🍏
DefaultSyncJobFactory.java 90.06% 🍏
JobCreationAndStatusUpdateActivityImpl.java 88.21% 🍏
DockerUtils.java 62.96% 🍏
CombinedConnectorCatalogGenerator.java 52.29% ❌
GenerateInputActivityImpl.java 1.19% ❌
Total Project Coverage 24.53% ❌

@colesnodgrass colesnodgrass merged commit 6d65070 into master Feb 1, 2023
@colesnodgrass colesnodgrass deleted the revert-21756-cole/rem-commons-docker branch February 1, 2023 20:43
colesnodgrass added a commit that referenced this pull request Feb 1, 2023
@colesnodgrass
Revert "Revert "remove airbyte-commons-docker (#21756)" (#22237)"
e9ae3ad 
This reverts commit 6d65070.
@colesnodgrass colesnodgrass mentioned this pull request Feb 1, 2023
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 2, 2023
Closed
colesnodgrass added a commit that referenced this pull request Feb 6, 2023
@colesnodgrass
Revert "Revert "remove airbyte-commons-docker (#21756)" (#22237)" (#2…
f098287 
…2239)

This reverts commit 6d65070.
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
This was referenced Feb 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephkmh josephkmh josephkmh approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform area/server area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colesnodgrass @josephkmh @octavia-squidington-iii