Go back v0 as default #22278
Merged
Go back v0 as default #22278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update config to specify v0 as max protocol version * revert back v0 ser/de to use the objects from the unversioned namespace * disable v1 migrations * fix the default to allow MigrationContainer to run without a migration
octavia-squidington-iii
added
area/platform
This reverts commit 99044eb.
Platform Test Results 239 files - 4 239 suites - 4 12m 7s ⏱️ - 12m 10s For more details on these failures, see this check. Results for commit c0eedfe. ± Comparison against base commit 6d65070. ♻️ This comment has been updated with latest results. |
edgao
approved these changes
Feb 2, 2023
| } | ||
|
|
||
| /** | ||
| * Performs of search of a v0 data type node, returns true at the first node found. |
There was a problem hiding this comment.
Suggested change
| * Performs of search of a v0 data type node, returns true at the first node found. | |
| * Performs of search of a v1 data type node, returns true at the first node found. |
Airbyte Code Coverage
|
colesnodgrass
approved these changes
Feb 2, 2023
|
/approve-and-merge reason=“Merging to unblock downtream steps, will keep an eye on the result" |
|
A crack team of mammals has made a decision. |
octavia-approvington
approved these changes
Feb 2, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses complications with upgrading the platform and normalization to support V1 protocol changes. This change will focus on making sure that platform is downgrading V1 protocols on-the-fly to ensure the catalog stored is V0. This effort will need to be in coordination with the normalization being downgraded to support V0 protocol
How
Adjust changes that were made to update the protocol version to V1 to go back and support V0 protocol until the migration process can be handled
Recommended reading order
x.javay.python