-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go back v0 as default #22278
Go back v0 as default #22278
Conversation
* update config to specify v0 as max protocol version * revert back v0 ser/de to use the objects from the unversioned namespace * disable v1 migrations * fix the default to allow MigrationContainer to run without a migration
This reverts commit 99044eb.
Platform Test Results 239 files - 4 239 suites - 4 12m 7s ⏱️ - 12m 10s For more details on these failures, see this check. Results for commit c0eedfe. ± Comparison against base commit 6d65070. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit on a comment. Code changes look right. I don't feel qualified to say if there were any files that should have been changed, that were missed though.
} | ||
|
||
/** | ||
* Performs of search of a v0 data type node, returns true at the first node found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Performs of search of a v0 data type node, returns true at the first node found. | |
* Performs of search of a v1 data type node, returns true at the first node found. |
Airbyte Code Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem fine. What's the confidence that the downgrade code works as expected?
/approve-and-merge reason=“Merging to unblock downtream steps, will keep an eye on the result" |
What
Addresses complications with upgrading the platform and normalization to support V1 protocol changes. This change will focus on making sure that platform is downgrading V1 protocols on-the-fly to ensure the catalog stored is V0. This effort will need to be in coordination with the normalization being downgraded to support V0 protocol
How
Adjust changes that were made to update the protocol version to V1 to go back and support V0 protocol until the migration process can be handled
Recommended reading order
x.java
y.python