CDK: improve day_delta macro and MinMaxDatetime component
#22400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
14 tasks
brianjlai
reviewed
Feb 6, 2023
There was a problem hiding this comment.
So the basic functionality is that when a provided datetime is earlier, then we set it to the boundary. When developing a connector, was there a limitation of the MinMaxDatetime component that prevented you from using instead of the macro? And if there was, maybe we could try to fold the functionality into the existing component instead of a new jinja macro
|
oops it seems I have missed that mix/max feature of datetime param |
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
grubberr
changed the title
day_delta macro and MinMaxDatetime component
|
I have removed that new macro |
brianjlai
approved these changes
Feb 8, 2023
airbyte-cdk/python/airbyte_cdk/sources/declarative/datetime/min_max_datetime.py
Show resolved
Hide resolved
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
brianjlai
approved these changes
Feb 8, 2023
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
…q#22400) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Chvalyuk grubberr@gmail.com
What
day_delta- add 2-nd optional parameterformatMinMaxDatetime- skip min or maxdatetimeif result of evaluation is empty string