source Aha: new fields - comments, endorsements, categories for ideas #22642

Upgreydd · 2023-02-09T14:01:18Z

What

Adds new fields: endorsements (votes), comments for ideas, and categories for products

How

CDK

🚨 User Impact 🚨

Possible to synchronize comments, endorsements (votes), and categories

marcosmarxm

some comments.

airbyte-integrations/connectors/source-aha/source_aha/manifest.yaml

Upgreydd · 2023-02-10T09:26:02Z

some comments.

Thank you @marcosmarxm. I did the cleanup of redundant parts.

marcosmarxm · 2023-02-13T21:44:33Z

/test connector=connectors/source-aha

🕑 connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/4168112062
❌ connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/4168112062
🐛 https://gradle.com/s/5rr4m476drags

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
=================== 3 failed, 30 passed, 2 skipped in 35.97s ===================

marcosmarxm · 2023-02-13T22:14:06Z

@Upgreydd can you check failed tests?

Upgreydd · 2023-02-14T15:35:21Z

@Upgreydd can you check failed tests?

@marcosmarxm
It's related to limited API key/aha plan to access features and goals options. Looks like airbyte has a limited key too (so do I). It's not related to my PR at all cause the same test fails in the master. The only option to test it without a good API key is to remove tests for features and goals I guess?

Upgreydd · 2023-02-20T10:07:15Z

@marcosmarxm I've removed checks for goals and features because they are optional and my API key and airbyte API key doesn't cover that part - that's why it fails tests.
Rebased on the new version with manifest.yaml changes from master and fixed definitions and structure.

marcosmarxm · 2023-03-03T16:06:09Z

/test connector=connectors/source-aha

🕑 connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/4325176674
❌ connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/4325176674
🐛 https://gradle.com/s/vv24wvfyvbj2u

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
=================== 3 failed, 30 passed, 2 skipped in 29.44s ===================

phdmohamedali · 2023-03-17T11:50:52Z

any updates on this

Upgreydd · 2023-04-15T06:43:03Z

any updates on this

My part works as expected, Issue is with base code. No idea why it's not checked while running CI

sh4sh · 2023-05-26T16:08:48Z

/test connector=connectors/source-aha

🕑 connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/5092814906
❌ connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/5092814906
🐛 https://gradle.com/s/tz5vl6mvhodwy

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: All ...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
=================== 1 failed, 35 passed, 2 skipped in 56.31s ===================

sh4sh · 2023-05-26T16:46:22Z

Seeded streams in the integration testing account

sh4sh · 2023-05-26T16:46:27Z

/test connector=connectors/source-aha

🕑 connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/5093112366
❌ connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/5093112366
🐛 https://gradle.com/s/fhrodxdpdkbus

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
=================== 1 failed, 35 passed, 2 skipped in 56.16s ===================

archangelic · 2023-05-30T21:11:30Z

/test connector=connectors/source-aha

🕑 connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/5126307406
✅ connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/5126307406
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
=================== 37 passed, 2 skipped in 61.10s (0:01:01) ===================

changes already made

…airbytehq#22642) * AHA.IO new fields * fix schemas * bump version --------- Co-authored-by: sh4sh <6833405+sh4sh@users.noreply.github.com> Co-authored-by: Mal Hancock <mallory@archangelic.space>

octavia-squidington-iii added area/connectors Connector related issues bounty community connectors/source/aha labels Feb 9, 2023

Upgreydd force-pushed the aha.io_new_fields branch from cf509dc to 4129b16 Compare February 9, 2023 14:02

marcosmarxm previously requested changes Feb 9, 2023

View reviewed changes

airbyte-integrations/connectors/source-aha/source_aha/manifest.yaml Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-aha/source_aha/manifest.yaml Outdated Show resolved Hide resolved

Upgreydd requested a review from marcosmarxm February 10, 2023 09:25

Upgreydd changed the title ~~source Aha: new fields - comments, votes, categories for ideas~~ source Aha: new fields - comments, endorsements, categories for ideas Feb 13, 2023

Upgreydd force-pushed the aha.io_new_fields branch 2 times, most recently from 415db64 to ab3015f Compare February 20, 2023 10:02

AHA.IO new fields

afb7ae5

Upgreydd force-pushed the aha.io_new_fields branch from ab3015f to afb7ae5 Compare February 20, 2023 10:15

marcosmarxm added the pr-alpha-beta label Apr 14, 2023

marcosmarxm assigned archangelic Apr 14, 2023

marcosmarxm unassigned archangelic May 12, 2023

marcosmarxm added community-legacy and removed community labels May 15, 2023

marcosmarxm added community and removed community-legacy labels May 26, 2023

Merge branch 'master' into aha.io_new_fields

28d9ab0

Merge branch 'master' into aha.io_new_fields

e7a5599

fix schemas

0e7e50e

archangelic added 2 commits May 30, 2023 14:37

Merge remote-tracking branch 'origin' into aha.io_new_fields

6deb39d

bump version

6b2e5b9

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 30, 2023

archangelic approved these changes May 30, 2023

View reviewed changes

archangelic merged commit c5936f0 into airbytehq:master May 30, 2023
46 of 51 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

source Aha: new fields - comments, endorsements, categories for ideas #22642

source Aha: new fields - comments, endorsements, categories for ideas #22642

Upgreydd commented Feb 9, 2023 •

edited

Loading

marcosmarxm left a comment

Upgreydd commented Feb 10, 2023

marcosmarxm commented Feb 13, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Feb 13, 2023

Upgreydd commented Feb 14, 2023

Upgreydd commented Feb 20, 2023

marcosmarxm commented Mar 3, 2023 •

edited by github-actions bot

Loading

phdmohamedali commented Mar 17, 2023

Upgreydd commented Apr 15, 2023

sh4sh commented May 26, 2023 •

edited by github-actions bot

Loading

sh4sh commented May 26, 2023

sh4sh commented May 26, 2023 •

edited by github-actions bot

Loading

archangelic commented May 30, 2023 •

edited by github-actions bot

Loading

source Aha: new fields - comments, endorsements, categories for ideas #22642

source Aha: new fields - comments, endorsements, categories for ideas #22642

Conversation

Upgreydd commented Feb 9, 2023 • edited Loading

What

How

🚨 User Impact 🚨

marcosmarxm left a comment

Choose a reason for hiding this comment

Upgreydd commented Feb 10, 2023

marcosmarxm commented Feb 13, 2023 • edited by github-actions bot Loading

Build Failed

marcosmarxm commented Feb 13, 2023

Upgreydd commented Feb 14, 2023

Upgreydd commented Feb 20, 2023

marcosmarxm commented Mar 3, 2023 • edited by github-actions bot Loading

Build Failed

phdmohamedali commented Mar 17, 2023

Upgreydd commented Apr 15, 2023

sh4sh commented May 26, 2023 • edited by github-actions bot Loading

Build Failed

sh4sh commented May 26, 2023

sh4sh commented May 26, 2023 • edited by github-actions bot Loading

Build Failed

archangelic commented May 30, 2023 • edited by github-actions bot Loading

Build Passed

Upgreydd commented Feb 9, 2023 •

edited

Loading

marcosmarxm commented Feb 13, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 3, 2023 •

edited by github-actions bot

Loading

sh4sh commented May 26, 2023 •

edited by github-actions bot

Loading

sh4sh commented May 26, 2023 •

edited by github-actions bot

Loading

archangelic commented May 30, 2023 •

edited by github-actions bot

Loading