Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Microsoft Dataverse: Fixed deduped not working correctly #22805

Merged
merged 6 commits into from Mar 16, 2023

Conversation

marcelopio
Copy link
Contributor

What

Due to delete only containing id, the deduped dbt could not work properly, because to check the start and end dates, deduped needs the cursor field to also be filled

How

Fill the cursor field with the current date so it does have a properly end

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Due to delete only containing id, the deduped dbt could not work
properly, so we also fill the cursor field with the current date
so it does have a properly end
@marcelopio marcelopio changed the title source-microsoft-dataverse: Fixed deduped not working correctly Source Microsoft Dataverse: Fixed deduped not working correctly Feb 10, 2023
@marcelopio marcelopio marked this pull request as ready for review February 23, 2023 00:07
@marcelopio marcelopio changed the title Source Microsoft Dataverse: Fixed deduped not working correctly 🐛 Source Microsoft Dataverse: Fixed deduped not working correctly Feb 23, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 16, 2023
@marcosmarxm
Copy link
Member

marcosmarxm commented Mar 16, 2023

/publish connector=connectors/source-microsoft-dataverse run-tests=false

🕑 Publishing the following connectors:
connectors/source-microsoft-dataverse
https://github.com/airbytehq/airbyte/actions/runs/4437611041


Connector Did it publish? Were definitions generated?
connectors/source-microsoft-dataverse

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm
Copy link
Member

This is an alpha connector and we don't have credentials yet because of this publishing without testing. Waiting for https://github.com/airbytehq/airbyte-internal-issues/issues/2645

@marcosmarxm marcosmarxm merged commit 60322fa into airbytehq:master Mar 16, 2023
36 of 42 checks passed
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
…rbytehq#22805)

* Fixed dedupeot working correctly

Due to delete only containing id, the deduped dbt could not work
properly, so we also fill the cursor field with the current date
so it does have a properly end

* bump connector version

* auto-bump connector version

---------

Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
…2805)

* Fixed dedupeot working correctly

Due to delete only containing id, the deduped dbt could not work
properly, so we also fill the cursor field with the current date
so it does have a properly end

* bump connector version

* auto-bump connector version

---------

Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
…2805)

* Fixed dedupeot working correctly

Due to delete only containing id, the deduped dbt could not work
properly, so we also fill the cursor field with the current date
so it does have a properly end

* bump connector version

* auto-bump connector version

---------

Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/microsoft-dataverse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants