Source Typeform: Mark datefields in spec as dates #22824

arsenlosenko · 2023-02-10T15:40:18Z

What

Resovling:
#22790

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-10T15:45:04Z

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/4145433497
❌ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/4145433497
🐛 https://gradle.com/s/rovwwdie2lnay

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
=================== 1 failed, 35 passed, 1 skipped in 41.32s ===================

arsenlosenko · 2023-02-21T11:14:29Z

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/4232063527
❌ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/4232063527
🐛 https://gradle.com/s/qohzc7oehxyxo

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
=================== 1 failed, 35 passed, 1 skipped in 44.95s ===================

lazebnyi · 2023-04-03T11:07:07Z

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/4595945745
❌ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/4595945745
🐛 https://gradle.com/s/trvp6wrm3pap4

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream forms...
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
=================== 2 failed, 34 passed, 1 skipped in 51.78s ===================

arsenlosenko · 2023-04-03T15:37:13Z

/test connector=connectors/source-typeform

🕑 connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/4598596522
✅ connectors/source-typeform https://github.com/airbytehq/airbyte/actions/runs/4598596522
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_typeform/__init__.py       2      0   100%
source_typeform/source.py       149      8    95%
-------------------------------------------------
TOTAL                           151      8    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 39 passed, 1 skipped in 48.58s ========================

arsenlosenko · 2023-04-03T17:23:02Z

/publish connector=connectors/source-typeform

🕑 Publishing the following connectors:
connectors/source-typeform
https://github.com/airbytehq/airbyte/actions/runs/4599543240

Connector	Did it publish?	Were definitions generated?
connectors/source-typeform	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Source Typeform: Mark datefields in spec as dates

ea86e95

arsenlosenko self-assigned this Feb 10, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/typeform labels Feb 10, 2023

arsenlosenko linked an issue Feb 10, 2023 that may be closed by this pull request

Source Typeform: Mark datefields in properly as dates #22790

Closed

arsenlosenko temporarily deployed to more-secrets February 10, 2023 15:42 — with GitHub Actions Inactive

Update changelog

c8f2421

arsenlosenko temporarily deployed to more-secrets February 10, 2023 15:46 — with GitHub Actions Inactive

Merge branch 'master' into arsenlosenko/source-typeform-format-date

2435888

arsenlosenko added 2 commits April 3, 2023 14:18

Merge branch 'master' into arsenlosenko/source-typeform-format-date

f6e6975

Update Dockerfile

a48cebc

arsenlosenko marked this pull request as ready for review April 3, 2023 11:18

arsenlosenko requested a review from lazebnyi April 3, 2023 11:19

Merge branch 'master' into arsenlosenko/source-typeform-format-date

d33e274

lazebnyi approved these changes Apr 3, 2023

View reviewed changes

octavia-squidington-iii and others added 2 commits April 3, 2023 17:35

auto-bump connector version

ce259ee

Merge branch 'master' into arsenlosenko/source-typeform-format-date

aa0f661

arsenlosenko merged commit a8e452a into master Apr 3, 2023
24 checks passed

arsenlosenko deleted the arsenlosenko/source-typeform-format-date branch April 3, 2023 18:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Typeform: Mark datefields in spec as dates #22824

Source Typeform: Mark datefields in spec as dates #22824

arsenlosenko commented Feb 10, 2023

arsenlosenko commented Feb 10, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

lazebnyi commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Source Typeform: Mark datefields in spec as dates #22824

Source Typeform: Mark datefields in spec as dates #22824

Conversation

arsenlosenko commented Feb 10, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 10, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Feb 21, 2023 • edited by github-actions bot

Build Failed

lazebnyi commented Apr 3, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot

Build Passed

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot

arsenlosenko commented Feb 10, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

lazebnyi commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot