🎉Source Stripe: New Stream - Early Fraud Warnings #22859

btkcodedev · 2023-02-11T08:38:28Z

What

Closes #16962

Enhancement

New streams:

Early fraud warnings

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter [Yes]

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Issue acceptance criteria met
PR name follows PR naming conventions
Documentation which references the generator is updated as needed

For the reviewer:

Enhancement passing in local python integration tests. Needs only to test deployment to cloud build and publish it :)

YowanR · 2023-02-24T17:10:41Z

@sh4sh @natalyjazzviolin can you please take a look? 🙏

…arnings stream being empty.'

natalyjazzviolin · 2023-02-24T21:11:25Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4266300588
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4266300588
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_stripe/source.py                     22      0   100%
source_stripe/__init__.py                    2      0   100%
source_stripe/streams.py                   323     29    91%
source_stripe/availability_strategy.py      19      2    89%
------------------------------------------------------------
TOTAL                                      366     31    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
============ 55 passed, 1 skipped, 37 warnings in 319.02s (0:05:19) ============

btkcodedev · 2023-03-01T17:06:07Z

Thanks for the build @natalyjazzviolin.
Its succeeded I think, Is there any changes need to be done?

evantahler · 2023-03-10T18:35:05Z

@natalyjazzviolin those github checks are failing because I think we need a branch that's really in our repo (not a fork)

Create a non-forked branch based on this PR and test the below items on it

btkcodedev · 2023-03-11T21:38:12Z

@natalyjazzviolin Could I help for anything?

btkcodedev · 2023-03-14T15:26:58Z

@natalyjazzviolin @evantahler Little Bump Here :)

natalyjazzviolin · 2023-03-14T17:29:46Z

@evantahler sorry for the confusion - my understanding was that a review is required by the connector Ops team because this is a GA connector. I've created a non-forked branch to run the build, it's still running as I type this so don't know if it's passed.

evantahler · 2023-03-14T21:13:49Z

Testing and deploying from #24062

btkcodedev · 2023-05-07T11:42:48Z

Secrets are available from lastpass

btkcodedev · 2023-05-07T11:43:54Z

I can't seed the stream as it doesn't support POST operation, however added it as empty stream.

erohmensing

Seems simple enough! Made a suggestion around correct version bumping. Good from the connector ops side once the version is updated. Please also fill out the checklist from the checklist action :)

erohmensing · 2023-05-09T13:33:54Z

airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml

@@ -2041,7 +2041,7 @@
 - name: Stripe
  sourceDefinitionId: e094cb9a-26de-4645-8761-65c0c425d1de
  dockerRepository: airbyte/source-stripe
-  dockerImageTag: 3.4.2
+  dockerImageTag: 3.5.2


Suggested change

dockerImageTag: 3.5.2

dockerImageTag: 3.5.0

When bumping minor versions, please bump back to .0 :)

erohmensing · 2023-05-09T13:35:13Z

docs/integrations/sources/stripe.md

-| 3.4.1   | 2023-04-24 | [23389](https://github.com/airbytehq/airbyte/pull/23389) | Add `customer_tax_ids` to `Invoices` |
-| 3.4.0   | 2023-03-20 | [23963](https://github.com/airbytehq/airbyte/pull/23963) | Add `SetupIntents` stream |
-| 3.3.0   | 2023-04-12 | [25136](https://github.com/airbytehq/airbyte/pull/25136) | Add stream `Accounts`                                                        |
+| 3.5.2   | 2023-05-10 | [22859](https://github.com/airbytehq/airbyte/pull/22859) | Added stream `Early Fraud Warnings`                                                                                                                  |


Suggested change

| 3.5.2 | 2023-05-10 | [22859](https://github.com/airbytehq/airbyte/pull/22859) | Added stream `Early Fraud Warnings` |

| 3.5.0 | 2023-05-10 | [22859](https://github.com/airbytehq/airbyte/pull/22859) | Added stream `Early Fraud Warnings` |

airbyte-integrations/connectors/source-stripe/acceptance-test-config.yml

airbyte-integrations/connectors/source-stripe/Dockerfile

sajarin · 2023-05-18T19:45:17Z

@btkcodedev can you rebase on master and address the comments above?

Co-authored-by: Augustin <augustin@airbyte.io>

btkcodedev · 2023-05-20T18:03:08Z

@sajarin All comments resolved, Conflicts resolved & Version bumped.
Thanks :)

marcosmarxm · 2023-05-22T17:24:40Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/5048672927
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/5048672927
🐛 https://gradle.com/s/udkcx4xc5tr5k

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream custo...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
============= 1 failed, 38 passed, 1 skipped in 288.06s (0:04:48) ==============

marcosmarxm · 2023-05-23T00:10:25Z

Waiting #26360 to fix the CI for Stripe.

marcosmarxm · 2023-05-23T20:00:56Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/5061527103
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/5061527103
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_stripe/source.py                     22      0   100%
source_stripe/__init__.py                    2      0   100%
source_stripe/availability_strategy.py      19      2    89%
source_stripe/streams.py                   339     37    89%
------------------------------------------------------------
TOTAL                                      382     39    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 39 passed, 1 skipped in 313.03s (0:05:13) ===================

* feat: New Strea: Early Fraud Warnings * Fixes formatting errors. * Updates the number of streams to assert in unit test. * Fixes error in TestBasicRead::test_read[inputs2] due to early_fraud_warnings stream being empty.' * rebase to master, fix schema * fix schema, tests * add as empty stream, fix sample file * fix tests, update docs, update version * add additional_properties * Update airbyte-integrations/connectors/source-stripe/Dockerfile Co-authored-by: Augustin <augustin@airbyte.io> * Resolve conflicts * Bump version, Resolve comments * remove incr for stream early_fraud * fix configured catalogs * fix unit test --------- Co-authored-by: Nataly Merezhuk <65251165+natalyjazzviolin@users.noreply.github.com> Co-authored-by: nataly <nataly@airbyte.io> Co-authored-by: Augustin <augustin@airbyte.io> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>

feat: New Strea: Early Fraud Warnings

df45266

octavia-squidington-iii added area/connectors Connector related issues bounty community connectors/source/stripe labels Feb 11, 2023

Merge branch 'master' into enhanceStripe

de1eebc

btkcodedev mentioned this pull request Feb 11, 2023

Source Stripe: new stream Early Fraud Warning #16962

Closed

YowanR requested review from sh4sh and natalyjazzviolin February 24, 2023 17:10

natalyjazzviolin and others added 2 commits February 24, 2023 14:37

Merge branch 'master' into enhanceStripe

952ef1a

Fixes formatting errors.

b7e39ef

This comment was marked as outdated.

Sign in to view

Updates the number of streams to assert in unit test.

840fd74

This comment was marked as outdated.

Sign in to view

Fixes error in TestBasicRead::test_read[inputs2] due to early_fraud_w…

5eb7c1f

…arnings stream being empty.'

Merge branch 'master' into enhanceStripe

0491e5e

natalyjazzviolin added the from/connector-ops label Mar 10, 2023

natalyjazzviolin requested review from evantahler, alafanechere and erohmensing March 10, 2023 18:25

Merge branch 'master' into enhanceStripe

309321d

natalyjazzviolin mentioned this pull request Mar 14, 2023

[non-forked] Source Stripe: New Stream - Early Fraud Warnings #24062

Closed

37 tasks

erohmensing approved these changes May 9, 2023

View reviewed changes

alafanechere reviewed May 11, 2023

View reviewed changes

airbyte-integrations/connectors/source-stripe/Dockerfile Outdated Show resolved Hide resolved

marcosmarxm unassigned sajarin May 12, 2023

marcosmarxm added community-legacy and removed community labels May 15, 2023

jrolom removed the bounty label May 19, 2023

evantahler removed request for evantahler and natalyjazzviolin May 19, 2023 18:17

marcosmarxm added the community label May 19, 2023

btkcodedev and others added 4 commits May 20, 2023 23:20

Update airbyte-integrations/connectors/source-stripe/Dockerfile

7cc31fc

Co-authored-by: Augustin <augustin@airbyte.io>

Resolve conflicts

5fb6a78

Merge branch 'master' into enhanceStripe

2fae812

Bump version, Resolve comments

4263df8

marcosmarxm and others added 4 commits May 22, 2023 11:59

Merge branch 'master' into enhanceStripe

adab144

remove incr for stream early_fraud

e3df5f4

fix configured catalogs

0d4413b

fix unit test

25690cd

Merge branch 'master' into enhanceStripe

b5b86d7

marcosmarxm approved these changes May 23, 2023

View reviewed changes

marcosmarxm merged commit ec4cf8d into airbytehq:master May 24, 2023
37 of 46 checks passed

marcosmarxm removed the community-legacy label Aug 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉Source Stripe: New Stream - Early Fraud Warnings #22859

🎉Source Stripe: New Stream - Early Fraud Warnings #22859

btkcodedev commented Feb 11, 2023 •

edited

YowanR commented Feb 24, 2023

This comment was marked as outdated.

This comment was marked as outdated.

natalyjazzviolin commented Feb 24, 2023 •

edited by github-actions bot

btkcodedev commented Mar 1, 2023

evantahler commented Mar 10, 2023

btkcodedev commented Mar 11, 2023

btkcodedev commented Mar 14, 2023

natalyjazzviolin commented Mar 14, 2023

evantahler commented Mar 14, 2023

btkcodedev commented May 7, 2023

btkcodedev commented May 7, 2023

erohmensing left a comment

erohmensing May 9, 2023

erohmensing May 9, 2023

sajarin commented May 18, 2023

btkcodedev commented May 20, 2023

marcosmarxm commented May 22, 2023 •

edited by github-actions bot

marcosmarxm commented May 23, 2023

marcosmarxm commented May 23, 2023 •

edited by github-actions bot

	\| 3.5.2 \| 2023-05-10 \| [22859](https://github.com/airbytehq/airbyte/pull/22859) \| Added stream `Early Fraud Warnings` \|
	\| 3.5.0 \| 2023-05-10 \| [22859](https://github.com/airbytehq/airbyte/pull/22859) \| Added stream `Early Fraud Warnings` \|

🎉Source Stripe: New Stream - Early Fraud Warnings #22859

🎉Source Stripe: New Stream - Early Fraud Warnings #22859

Conversation

btkcodedev commented Feb 11, 2023 • edited

What

Enhancement

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter [Yes]

For the reviewer:

YowanR commented Feb 24, 2023

This comment was marked as outdated.

This comment was marked as outdated.

natalyjazzviolin commented Feb 24, 2023 • edited by github-actions bot

Build Passed

btkcodedev commented Mar 1, 2023

evantahler commented Mar 10, 2023

btkcodedev commented Mar 11, 2023

btkcodedev commented Mar 14, 2023

natalyjazzviolin commented Mar 14, 2023

evantahler commented Mar 14, 2023

btkcodedev commented May 7, 2023

btkcodedev commented May 7, 2023

erohmensing left a comment

Choose a reason for hiding this comment

erohmensing May 9, 2023

Choose a reason for hiding this comment

erohmensing May 9, 2023

Choose a reason for hiding this comment

sajarin commented May 18, 2023

btkcodedev commented May 20, 2023

marcosmarxm commented May 22, 2023 • edited by github-actions bot

Build Failed

marcosmarxm commented May 23, 2023

marcosmarxm commented May 23, 2023 • edited by github-actions bot

Build Passed

btkcodedev commented Feb 11, 2023 •

edited

natalyjazzviolin commented Feb 24, 2023 •

edited by github-actions bot

marcosmarxm commented May 22, 2023 •

edited by github-actions bot

marcosmarxm commented May 23, 2023 •

edited by github-actions bot