Source PayPal Transaction: Mark datefields in spec as dates #22916

arsenlosenko · 2023-02-13T13:48:49Z

What

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-13T13:49:01Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4164110159

…mat-date

arsenlosenko · 2023-02-14T10:05:02Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4172640369

…mat-date

arsenlosenko · 2023-02-21T11:21:45Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4232121795
❌ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4232121795
🐛 https://gradle.com/s/6rtjljb63m5pe

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============== 1 failed, 37 passed, 1 skipped in 86.76s (0:01:26) ==============

arsenlosenko · 2023-02-21T13:54:20Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4233365421
❌ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4233365421
🐛 https://gradle.com/s/odgvrbveieu4y

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============== 1 failed, 37 passed, 1 skipped in 96.62s (0:01:36) ==============

…mat-date

arsenlosenko · 2023-02-22T12:26:52Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4242681148
❌ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4242681148
🐛 https://gradle.com/s/bwdl3ny6rxpum

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============== 1 failed, 37 passed, 1 skipped in 89.96s (0:01:29) ==============

…mat-date

arsenlosenko · 2023-04-03T08:13:54Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4594402499
✅ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4594402499
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_paypal_transaction/utils.py          8      0   100%
source_paypal_transaction/__init__.py       2      0   100%
source_paypal_transaction/source.py       275     13    95%
-----------------------------------------------------------
TOTAL                                     285     13    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 41 passed, 1 skipped in 105.78s (0:01:45) ===================

arsenlosenko · 2023-04-04T10:33:47Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4606758913
❌ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4606758913
🐛 https://gradle.com/s/igu63462xkpbu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_config_match_spec[inputs0] - Failed: Conf...
FAILED test_core.py::TestSpec::test_backward_compatibility[inputs0] - connect...
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: A ...
FAILED test_core.py::TestConnection::test_check[inputs2] - AssertionError: as...
FAILED test_core.py::TestConnection::test_check[inputs3] - AssertionError: A ...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 7 failed, 22 passed, 13 errors in 16.96s ===================

arsenlosenko · 2023-04-04T12:14:06Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4607585444
❌ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4607585444
🐛 https://gradle.com/s/5v7sqabj2g3vm

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_config_match_spec[inputs0] - Failed: Conf...
FAILED test_core.py::TestSpec::test_backward_compatibility[inputs0] - connect...
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: A ...
FAILED test_core.py::TestConnection::test_check[inputs2] - AssertionError: as...
FAILED test_core.py::TestConnection::test_check[inputs3] - AssertionError: A ...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 7 failed, 22 passed, 13 errors in 17.78s ===================

…mat-date

arsenlosenko · 2023-04-25T15:13:35Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4799178768
✅ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4799178768
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_paypal_transaction/utils.py          8      0   100%
source_paypal_transaction/__init__.py       2      0   100%
source_paypal_transaction/source.py       275     13    95%
-----------------------------------------------------------
TOTAL                                     285     13    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.1.12.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:587: Backward compatibility tests are disabled for version 0.1.12.
================== 40 passed, 2 skipped in 107.02s (0:01:47) ===================

…ime with offset

arsenlosenko · 2023-04-26T12:23:19Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4808615854
✅ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4808615854
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_paypal_transaction/utils.py          8      0   100%
source_paypal_transaction/__init__.py       2      0   100%
source_paypal_transaction/source.py       275     13    95%
-----------------------------------------------------------
TOTAL                                     285     13    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 41 passed, 1 skipped in 115.12s (0:01:55) ===================

arsenlosenko · 2023-04-26T12:40:45Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4808781522
✅ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4808781522
Python tests coverage:

Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
source_paypal_transaction/utils.py          8      0   100%
source_paypal_transaction/__init__.py       2      0   100%
source_paypal_transaction/source.py       275     13    95%
-----------------------------------------------------------
TOTAL                                     285     13    95%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 41 passed, 1 skipped in 105.21s (0:01:45) ===================

arsenlosenko · 2023-04-26T13:00:39Z

/publish connector=connectors/source-paypal-transaction

🕑 Publishing the following connectors:
connectors/source-paypal-transaction
https://github.com/airbytehq/airbyte/actions/runs/4808986971

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-paypal-transaction	0.1.13	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…q#22916) * Source PayPal Transaction: Mark datefields in spec as dates * Update changelog * Update Dockerfile * Update regex pattern * Update config examples, and skip comparison with previous version * Update pattern regex to match both datetime from datepicker and datetime with offset * Remove previous changes in config examples * Update examples in spec * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Source PayPal Transaction: Mark datefields in spec as dates

5bc5ed1

arsenlosenko self-assigned this Feb 13, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 13, 2023

Update changelog

2d77974

octavia-squidington-iii added the connectors/source/paypal-transaction label Feb 13, 2023

Merge branch 'master' into arsenlosenko/source-paypal-transaction-for…

b3df48b

…mat-date

Merge branch 'master' into arsenlosenko/source-paypal-transaction-for…

aad87e2

…mat-date

Merge branch 'master' into arsenlosenko/source-paypal-transaction-for…

adbbd3d

…mat-date

arsenlosenko added 2 commits April 3, 2023 11:12

Merge branch 'master' into arsenlosenko/source-paypal-transaction-for…

dfd6988

…mat-date

Update Dockerfile

f8e9069

arsenlosenko marked this pull request as ready for review April 3, 2023 11:07

arsenlosenko requested a review from lazebnyi April 3, 2023 11:07

lazebnyi approved these changes Apr 3, 2023

View reviewed changes

Update regex pattern

7883fbf

arsenlosenko added 2 commits April 25, 2023 16:12

Merge branch 'master' into arsenlosenko/source-paypal-transaction-for…

0ba35f8

…mat-date

Update config examples, and skip comparison with previous version

eff2352

Update pattern regex to match both datetime from datepicker and datet…

d61d5af

…ime with offset

arsenlosenko added 2 commits April 26, 2023 15:38

Remove previous changes in config examples

c27859b

Update examples in spec

916522d

auto-bump connector version

14fe7be

arsenlosenko merged commit 0774d07 into master Apr 26, 2023
25 checks passed

arsenlosenko deleted the arsenlosenko/source-paypal-transaction-format-date branch April 26, 2023 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source PayPal Transaction: Mark datefields in spec as dates #22916

Source PayPal Transaction: Mark datefields in spec as dates #22916

arsenlosenko commented Feb 13, 2023

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 22, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 25, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot

Source PayPal Transaction: Mark datefields in spec as dates #22916

Source PayPal Transaction: Mark datefields in spec as dates #22916

Conversation

arsenlosenko commented Feb 13, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 13, 2023 • edited by github-actions bot

arsenlosenko commented Feb 14, 2023 • edited by github-actions bot

arsenlosenko commented Feb 21, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Feb 21, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Feb 22, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot

Build Passed

arsenlosenko commented Apr 4, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 4, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 25, 2023 • edited by github-actions bot

Build Passed

arsenlosenko commented Apr 26, 2023 • edited by github-actions bot

Build Passed

arsenlosenko commented Apr 26, 2023 • edited by github-actions bot

Build Passed

arsenlosenko commented Apr 26, 2023 • edited by github-actions bot

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 21, 2023 •

edited by github-actions bot

arsenlosenko commented Feb 22, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 25, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot