Source NASA: Mark datefields in spec as dates #22934

arsenlosenko · 2023-02-13T16:26:05Z

What

Resolving:
#22747

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-13T16:26:21Z

/test connector=connectors/source-nasa

🕑 connectors/source-nasa https://github.com/airbytehq/airbyte/actions/runs/4165570094
✅ connectors/source-nasa https://github.com/airbytehq/airbyte/actions/runs/4165570094
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_nasa/__init__.py       2      0   100%
source_nasa/source.py       122     23    81%
---------------------------------------------
TOTAL                       124     23    81%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1711    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============ 36 passed, 1 skipped, 37 warnings in 65.15s (0:01:05) =============

arsenlosenko · 2023-03-02T06:03:13Z

/test connector=connectors/source-nasa

🕑 connectors/source-nasa https://github.com/airbytehq/airbyte/actions/runs/4311080004
❌ connectors/source-nasa https://github.com/airbytehq/airbyte/actions/runs/4311080004
🐛 https://gradle.com/s/twpibbvqeh3ki

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - Failed: Timeout >3...
FAILED test_core.py::TestConnection::test_check[inputs1] - Failed: Timeout >3...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
======= 7 failed, 29 passed, 1 skipped, 37 warnings in 867.14s (0:14:27) =======

> Task :airbyte-integrations:connectors:source-nasa:connectorAcceptanceTest FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings
27 actionable tasks: 9 executed, 18 up-to-date

Publishing build scan...
https://gradle.com/s/twpibbvqeh3ki

S3 cache writes: 1, elapsed: 647ms, sent to cache: 445 B

arsenlosenko · 2023-03-02T08:18:11Z

/test connector=connectors/source-nasa

🕑 connectors/source-nasa https://github.com/airbytehq/airbyte/actions/runs/4311930628
✅ connectors/source-nasa https://github.com/airbytehq/airbyte/actions/runs/4311930628
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_nasa/__init__.py       2      0   100%
source_nasa/source.py       122     23    81%
---------------------------------------------
TOTAL                       124     23    81%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
============ 36 passed, 1 skipped, 37 warnings in 66.36s (0:01:06) =============

arsenlosenko · 2023-03-02T08:47:58Z

/publish connector=connectors/source-nasa

🕑 Publishing the following connectors:
connectors/source-nasa
https://github.com/airbytehq/airbyte/actions/runs/4312160210

Connector	Did it publish?	Were definitions generated?
connectors/source-nasa	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Source NASA: Mark datefields in spec as dates * Update changelog * Add allowedHosts * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Source NASA: Mark datefields in spec as dates

dfd3af0

arsenlosenko self-assigned this Feb 13, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 13, 2023

octavia-squidington-iii added the connectors/source/nasa label Feb 13, 2023

Update changelog

dae5fe3

arsenlosenko requested a review from lazebnyi February 13, 2023 16:50

arsenlosenko marked this pull request as ready for review February 13, 2023 16:50

lazebnyi approved these changes Feb 13, 2023

View reviewed changes

arsenlosenko and others added 4 commits February 14, 2023 12:06

Merge branch 'master' into arsenlosenko/source-nasa-format-date

5f96498

Merge branch 'master' into arsenlosenko/source-nasa-format-date

3194fec

Add allowedHosts

226e39b

Merge branch 'master' into arsenlosenko/source-nasa-format-date

fdad4fb

Merge branch 'master' into arsenlosenko/source-nasa-format-date

0770a71

auto-bump connector version

c7a4a53

arsenlosenko merged commit b56232e into master Mar 2, 2023

arsenlosenko deleted the arsenlosenko/source-nasa-format-date branch March 2, 2023 09:37

jbfbell mentioned this pull request Mar 15, 2023

Check With Catalog JDBC POC (feature flag default off) #24109

Closed

37 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source NASA: Mark datefields in spec as dates #22934

Source NASA: Mark datefields in spec as dates #22934

arsenlosenko commented Feb 13, 2023

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

Source NASA: Mark datefields in spec as dates #22934

Source NASA: Mark datefields in spec as dates #22934

Conversation

arsenlosenko commented Feb 13, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 13, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Mar 2, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Mar 2, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Mar 2, 2023 • edited by github-actions bot Loading

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 2, 2023 •

edited by github-actions bot

Loading