Source Marketo: Mark datefields in spec as dates #22938

arsenlosenko · 2023-02-13T16:44:35Z

What

Resolving:
#22744

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-13T16:44:46Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4165729244

arsenlosenko · 2023-02-14T10:00:47Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4172598134

arsenlosenko · 2023-03-03T06:27:24Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4320873052
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4320873052
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_marketo/__init__.py       2      0   100%
source_marketo/utils.py         33      1    97%
source_marketo/source.py       280     29    90%
------------------------------------------------
TOTAL                          315     30    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 36 passed, 1 skipped in 4892.25s (1:21:32) ==================

arsenlosenko · 2023-04-03T11:43:56Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4596257032
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4596257032
🐛 https://gradle.com/s/3lwprkvk3l3u6

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestBasicRead::test_read[inputs0] - Failed: High strictne...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 38 passed, 1 skipped, 1 error in 1900.13s (0:31:40) ==============

arsenlosenko · 2023-04-03T16:27:50Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4599057251
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4599057251
🐛 https://gradle.com/s/iqjt55ad4xdse

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestBasicRead::test_read[inputs0] - Failed: High strictne...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 38 passed, 1 skipped, 1 error in 1958.01s (0:32:38) ==============

arsenlosenko · 2023-04-06T09:16:44Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4627376423
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4627376423
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_marketo/__init__.py       2      0   100%
source_marketo/utils.py         33      1    97%
source_marketo/source.py       280     29    90%
------------------------------------------------
TOTAL                          315     30    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:587: Backward compatibility tests are disabled for version 1.0.2.
================== 39 passed, 1 skipped in 4777.20s (1:19:37) ==================

arsenlosenko · 2023-04-06T12:46:48Z

/publish connector=connectors/source-marketo

🕑 Publishing the following connectors:
connectors/source-marketo
https://github.com/airbytehq/airbyte/actions/runs/4629038209

Connector	Did it publish?	Were definitions generated?
connectors/source-marketo	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

arsenlosenko · 2023-04-07T08:28:36Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4636724523

rodireich · 2023-04-11T19:01:46Z

@arsenlosenko I noticed this merged touched /airbyte-config/init/src/main/resources/seed/oss_catalog.json .
In between the time this PR was created and merged the module name changed to /airbyte-config**-oss**/init**-oss**/…

It's hard to tell what your change is as there's no git history. Do you mind putting these changes in the updated file that is now used?

rodireich · 2023-04-11T19:04:49Z

Actually it's all in this commit
I'm updating the new file and will delete the old one. thanks

Source Marketo: Mark datefields in spec as dates

63293ed

arsenlosenko self-assigned this Feb 13, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/marketo labels Feb 13, 2023

arsenlosenko and others added 2 commits February 13, 2023 18:45

Update changelog

1eff826

Merge branch 'master' into arsenlosenko/source-marketo-format-date

fd90676

Merge branch 'master' into arsenlosenko/source-marketo-format-date

0635413

Merge branch 'master' into arsenlosenko/source-marketo-format-date

a034648

arsenlosenko marked this pull request as ready for review April 3, 2023 11:16

arsenlosenko requested a review from lazebnyi April 3, 2023 11:16

Merge branch 'master' into arsenlosenko/source-marketo-format-date

19bd36f

Merge branch 'master' into arsenlosenko/source-marketo-format-date

6247077

Merge branch 'master' into arsenlosenko/source-marketo-format-date

a9d008b

octavia-squidington-iii and others added 2 commits April 6, 2023 14:20

auto-bump connector version

ca0f51c

Merge branch 'master' into arsenlosenko/source-marketo-format-date

a01f4b5

lazebnyi approved these changes Apr 6, 2023

View reviewed changes

arsenlosenko added 2 commits April 7, 2023 11:21

Merge branch 'master' into arsenlosenko/source-marketo-format-date

0edc6c9

Merge branch 'master' into arsenlosenko/source-marketo-format-date

7df78e7

arsenlosenko and others added 2 commits April 7, 2023 08:41

Automated Change

85df4a6

Merge branch 'master' into arsenlosenko/source-marketo-format-date

d6a8558

arsenlosenko merged commit f9a62e8 into master Apr 7, 2023

arsenlosenko deleted the arsenlosenko/source-marketo-format-date branch April 7, 2023 17:07

rodireich mentioned this pull request Apr 11, 2023

Test all datatypes translation #25029

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Marketo: Mark datefields in spec as dates #22938

Source Marketo: Mark datefields in spec as dates #22938

arsenlosenko commented Feb 13, 2023

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 6, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 6, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 7, 2023 •

edited by github-actions bot

Loading

rodireich commented Apr 11, 2023

rodireich commented Apr 11, 2023

Source Marketo: Mark datefields in spec as dates #22938

Source Marketo: Mark datefields in spec as dates #22938

Conversation

arsenlosenko commented Feb 13, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 13, 2023 • edited by github-actions bot Loading

arsenlosenko commented Feb 14, 2023 • edited by github-actions bot Loading

arsenlosenko commented Mar 3, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot Loading

Build Failed

arsenlosenko commented Apr 6, 2023 • edited by github-actions bot Loading

Build Passed

arsenlosenko commented Apr 6, 2023 • edited by github-actions bot Loading

arsenlosenko commented Apr 7, 2023 • edited by github-actions bot Loading

rodireich commented Apr 11, 2023

rodireich commented Apr 11, 2023

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Mar 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 6, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 6, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 7, 2023 •

edited by github-actions bot

Loading