Source Intercom: Mark datefields in spec as dates #22980

arsenlosenko · 2023-02-14T10:14:02Z

What

Resolving:
#22737

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-14T10:14:15Z

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4172722272
❌ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4172722272
🐛 https://gradle.com/s/znufcnhbajbok

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 SKIPPED [9] integration_tests/integration_test.py:33: need to refresh this test, it is very slow
	 FAILED integration_tests/integration_test.py::test_companies_scroll - assert ...
	 FAILED integration_tests/integration_test.py::test_switch_to_standard_endpoint
	 �[31m============= �[31m�[1m2 failed�[0m, �[33m9 skipped�[0m, �[33m13 warnings�[0m�[31m in 67.63s (0:01:07)�[0m�[31m =============�[0m

arsenlosenko · 2023-03-04T16:10:06Z

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4331799984
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4331799984
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/utils.py         60      1    98%
source_intercom/source.py       256     22    91%
-------------------------------------------------
TOTAL                           318     23    93%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/utils.py         60      8    87%
source_intercom/source.py       256     43    83%
-------------------------------------------------
TOTAL                           318     51    84%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 36 passed, 1 skipped in 197.81s (0:03:17) ===================
	 =========================== short test summary info ============================
	 SKIPPED [9] integration_tests/integration_test.py:33: need to refresh this test, it is very slow
	 �[33m============= �[32m2 passed�[0m, �[33m�[1m9 skipped�[0m, �[33m�[1m63 warnings�[0m�[33m in 72.14s (0:01:12)�[0m�[33m =============�[0m

arsenlosenko · 2023-03-24T13:10:55Z

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4511547604
❌ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4511547604
🐛 https://gradle.com/s/3ontzjqhc7ovu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream admin...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 38 passed, 1 skipped in 276.06s (0:04:36) ==============

arsenlosenko · 2023-03-24T13:47:02Z

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4511861391
❌ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4511861391
🐛 https://gradle.com/s/wk2snvsldluzq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream admin...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 38 passed, 1 skipped in 260.52s (0:04:20) ==============

arsenlosenko · 2023-03-27T12:28:43Z

/test connector=connectors/source-intercom

arsenlosenko · 2023-03-28T12:31:30Z

/test connector=connectors/source-intercom

arsenlosenko · 2023-04-03T06:26:13Z

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4593588012
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/4593588012
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/utils.py         60      1    98%
source_intercom/source.py       256     22    91%
-------------------------------------------------
TOTAL                           318     23    93%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/utils.py         60      8    87%
source_intercom/source.py       256     43    83%
-------------------------------------------------
TOTAL                           318     51    84%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 39 passed, 1 skipped in 260.45s (0:04:20) ===================
	 =========================== short test summary info ============================
	 SKIPPED [9] integration_tests/integration_test.py:33: need to refresh this test, it is very slow
	 �[33m============= �[32m2 passed�[0m, �[33m�[1m9 skipped�[0m, �[33m�[1m63 warnings�[0m�[33m in 72.65s (0:01:12)�[0m�[33m =============�[0m

arsenlosenko · 2023-04-03T09:41:50Z

/publish connector=connectors/source-intercom

🕑 Publishing the following connectors:
connectors/source-intercom
https://github.com/airbytehq/airbyte/actions/runs/4595209291

Connector	Did it publish?	Were definitions generated?
connectors/source-intercom	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Source Intercom: Mark datefields in spec as dates

d16f387

arsenlosenko self-assigned this Feb 14, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/intercom labels Feb 14, 2023

arsenlosenko and others added 3 commits February 14, 2023 12:14

Update changelog

1018ae6

Merge branch 'master' into arsenlosenko/source-intercom-format-date

ddda0c8

Update Dockerfile

0f06c22

arsenlosenko added 2 commits March 24, 2023 15:07

Merge branch 'master' into arsenlosenko/source-intercom-format-date

66fd9d3

Update Dockerfile

59970dc

Merge branch 'master' into arsenlosenko/source-intercom-format-date

5ae2bc6

Merge branch 'master' into arsenlosenko/source-intercom-format-date

0459b73

arsenlosenko marked this pull request as ready for review April 3, 2023 06:26

arsenlosenko requested a review from lazebnyi April 3, 2023 08:30

Merge branch 'master' into arsenlosenko/source-intercom-format-date

817f595

lazebnyi approved these changes Apr 3, 2023

View reviewed changes

auto-bump connector version

5478c05

arsenlosenko merged commit c0f89ea into master Apr 3, 2023
24 checks passed

arsenlosenko deleted the arsenlosenko/source-intercom-format-date branch April 3, 2023 11:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Intercom: Mark datefields in spec as dates #22980

Source Intercom: Mark datefields in spec as dates #22980

arsenlosenko commented Feb 14, 2023

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 4, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 24, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 24, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 27, 2023

arsenlosenko commented Mar 28, 2023

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Source Intercom: Mark datefields in spec as dates #22980

Source Intercom: Mark datefields in spec as dates #22980

Conversation

arsenlosenko commented Feb 14, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 14, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Mar 4, 2023 • edited by github-actions bot

Build Passed

arsenlosenko commented Mar 24, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Mar 24, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Mar 27, 2023

arsenlosenko commented Mar 28, 2023

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot

Build Passed

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 4, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 24, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 24, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot