Source Facebook Marketing: Mark datefields in spec as dates #22999

arsenlosenko · 2023-02-14T13:45:25Z

What

Resolving:
#22724

How

add format: date-time for end_date in spec, remove code which removed it previously (saw that format was removed on purpose because of this oncall issue, tested if the issue is still persists with enabled datepicker, it does not, connector can be configured with or without end_date)

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-14T13:45:41Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4174430637
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4174430637
🐛 https://gradle.com/s/zvss6adekqwic

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
============= 1 failed, 34 passed, 2 skipped in 2169.27s (0:36:09) =============

…mat-date

arsenlosenko · 2023-03-03T14:24:17Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4324335449
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4324335449
🐛 https://gradle.com/s/o3fdwlm2ionw2

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
============= 2 failed, 33 passed, 2 skipped in 2133.05s (0:35:33) =============

…mat-date

arsenlosenko · 2023-03-04T15:59:55Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4331758360
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4331758360
🐛 https://gradle.com/s/a4ilzcfb4y5xa

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
============= 1 failed, 34 passed, 2 skipped in 2200.49s (0:36:40) =============

arsenlosenko · 2023-03-06T07:23:04Z

/test connector=connectors/source-facebook-marketing

…mat-date

arsenlosenko · 2023-03-17T08:12:25Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4445496828
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4445496828
🐛 https://gradle.com/s/zibd7erwedskw

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
============= 1 failed, 35 passed, 1 skipped in 2209.41s (0:36:49) =============

lazebnyi · 2023-04-03T11:06:27Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4595939343
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4595939343
🐛 https://gradle.com/s/bq6aewz4m25z4

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_source.py::test_check_config - pydantic.error_wrappers...
	 �[31m=================== �[31m�[1m1 failed�[0m, �[32m114 passed�[0m, �[33m1 warning�[0m�[31m in 1.60s�[0m�[31m ===================�[0m

…mat-date

arsenlosenko · 2023-04-03T16:31:57Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4599090620
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4599090620
🐛 https://gradle.com/s/m5hvna3l2wz2a

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 2 failed, 36 passed, 2 skipped in 2015.76s (0:33:35) =============

arsenlosenko · 2023-04-04T12:21:18Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4607651346
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4607651346
🐛 https://gradle.com/s/cum6wpzjnfsn6

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 2 failed, 36 passed, 2 skipped in 1701.37s (0:28:21) =============

…mat-date

arsenlosenko · 2023-04-06T07:13:07Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4626415293
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4626415293
🐛 https://gradle.com/s/ysfhpruxescqu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 1885.93s (0:31:25) =============

…mat-date

arsenlosenko · 2023-04-06T09:19:36Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4627399459
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4627399459
🐛 https://gradle.com/s/xmpx7ozrmyqwg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 1681.52s (0:28:01) =============

…mat-date

arsenlosenko · 2023-04-07T08:29:04Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4636727243
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4636727243
🐛 https://gradle.com/s/m7atd2kburpzq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 1524.37s (0:25:24) =============

arsenlosenko · 2023-04-11T07:29:15Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4664997629
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4664997629
🐛 https://gradle.com/s/3ex2mvn7tkh2o

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 2 failed, 36 passed, 2 skipped in 1708.28s (0:28:28) =============

…mat-date

arsenlosenko · 2023-04-25T13:10:48Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4797886653
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4797886653
🐛 https://gradle.com/s/bu6s3jsoqzzju

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream ads_i...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 2 failed, 36 passed, 2 skipped in 1460.52s (0:24:20) =============

…mat-date

arsenlosenko · 2023-04-25T14:42:39Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4798846894
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4798846894
🐛 https://gradle.com/s/basbfev6jnj3o

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 1448.71s (0:24:08) =============

…mat-date

arsenlosenko · 2023-04-25T16:55:43Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4800138713
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4800138713
🐛 https://gradle.com/s/yxrgc5rtr5hae

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 1888.05s (0:31:28) =============

…mat-date

arsenlosenko · 2023-04-26T06:54:51Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4805787654
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4805787654
🐛 https://gradle.com/s/ectku7qkwagjm

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 2 failed, 36 passed, 2 skipped in 1564.44s (0:26:04) =============

…mat-date

arsenlosenko · 2023-04-26T09:52:18Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4807315824
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4807315824
🐛 https://gradle.com/s/velsg4fnlwq5q

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 2 failed, 36 passed, 2 skipped in 1625.17s (0:27:05) =============

…mat-date

arsenlosenko · 2023-04-28T06:25:00Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4827721410
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4827721410
🐛

…mat-date

arsenlosenko · 2023-04-28T19:37:08Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4834159170
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4834159170
🐛 https://gradle.com/s/mvo3jevwmohuk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 1483.29s (0:24:43) =============

…mat-date

arsenlosenko · 2023-05-01T07:24:26Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4849409717
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4849409717
🐛 https://gradle.com/s/av66qi2ah5l3i

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 1686.30s (0:28:06) =============

arsenlosenko · 2023-05-03T10:27:53Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4870877229
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4870877229
🐛 https://gradle.com/s/s67pddyphoxpo

Build Failed

Test summary info:

Could not find result summary

…mat-date

arsenlosenko · 2023-05-03T10:59:36Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4871109745
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4871109745
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             26      0   100%
source_facebook_marketing/streams/common.py                    44      0   100%
source_facebook_marketing/streams/async_job.py                217      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              39      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/streams/patches.py                   22      2    91%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/source.py                            61      6    90%
source_facebook_marketing/streams/base_insight_streams.py     145     16    89%
source_facebook_marketing/streams/base_streams.py             143     22    85%
source_facebook_marketing/streams/streams.py                  125     29    77%
-------------------------------------------------------------------------------
TOTAL                                                        1003     87    91%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              39      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/patches.py                   22      3    86%
source_facebook_marketing/streams/base_streams.py             143     28    80%
source_facebook_marketing/streams/common.py                    44     16    64%
source_facebook_marketing/utils.py                             26     10    62%
source_facebook_marketing/source.py                            61     24    61%
source_facebook_marketing/streams/streams.py                  125     50    60%
source_facebook_marketing/streams/base_insight_streams.py     145     64    56%
source_facebook_marketing/streams/async_job.py                217    136    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                        1003    403    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 39 passed, 1 skipped in 1814.73s (0:30:14) ==================

arsenlosenko · 2023-05-03T12:36:47Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/4871949639

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	0.3.6	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…q#22999) * Source Facebook Marketing: Mark datefields in spec as dates * Update changelog * Update Dockerfile * Update Dockerfile * Update Dockerfile * Automated Change * Enable date-time format for end_date again * Remove unused imports * auto-bump connector version --------- Co-authored-by: arsenlosenko <arsenlosenko@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Source Facebook Marketing: Mark datefields in spec as dates

79907af

arsenlosenko self-assigned this Feb 14, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 14, 2023

octavia-squidington-iii added the connectors/source/facebook-marketing label Feb 14, 2023

arsenlosenko and others added 3 commits February 14, 2023 15:46

Update changelog

310f132

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

0a08200

…mat-date

Update Dockerfile

997da3b

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

e4efeb4

…mat-date

arsenlosenko added 2 commits March 17, 2023 10:10

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

22f01e2

…mat-date

Update Dockerfile

b658169

arsenlosenko marked this pull request as ready for review April 3, 2023 11:12

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

19c0a25

…mat-date

arsenlosenko requested a review from lazebnyi April 3, 2023 11:15

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

af03df4

…mat-date

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

fec4a10

…mat-date

lazebnyi approved these changes Apr 6, 2023

View reviewed changes

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

ed4366c

…mat-date

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

41ae131

…mat-date

arsenlosenko and others added 2 commits April 11, 2023 07:49

Automated Change

604a19a

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

a88f846

…mat-date

arsenlosenko added 2 commits April 25, 2023 16:20

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

d39b623

…mat-date

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

18bbb9c

…mat-date

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

968a6b7

…mat-date

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

569697e

…mat-date

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

c9b5e94

…mat-date

arsenlosenko added 2 commits April 27, 2023 13:47

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

f4f6a74

…mat-date

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

17c5119

…mat-date

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

78b7988

…mat-date

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

f3a7c95

…mat-date

Enable date-time format for end_date again

a63b42b

arsenlosenko added 2 commits May 3, 2023 13:59

Remove unused imports

0c03199

Merge branch 'master' into arsenlosenko/source-facebook-marketing-for…

8e7117a

…mat-date

auto-bump connector version

233fff9

arsenlosenko merged commit e20fb9d into master May 3, 2023
27 of 28 checks passed

arsenlosenko deleted the arsenlosenko/source-facebook-marketing-format-date branch May 3, 2023 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Facebook Marketing: Mark datefields in spec as dates #22999

Source Facebook Marketing: Mark datefields in spec as dates #22999

arsenlosenko commented Feb 14, 2023 •

edited

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 3, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 4, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 6, 2023

arsenlosenko commented Mar 17, 2023 •

edited by github-actions bot

lazebnyi commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 6, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 6, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 7, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 11, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 25, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 25, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 25, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 28, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 28, 2023 •

edited by github-actions bot

arsenlosenko commented May 1, 2023 •

edited by github-actions bot

arsenlosenko commented May 3, 2023 •

edited by github-actions bot

arsenlosenko commented May 3, 2023 •

edited by github-actions bot

arsenlosenko commented May 3, 2023 •

edited by github-actions bot

Source Facebook Marketing: Mark datefields in spec as dates #22999

Source Facebook Marketing: Mark datefields in spec as dates #22999

Conversation

arsenlosenko commented Feb 14, 2023 • edited

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 14, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Mar 3, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Mar 4, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Mar 6, 2023

arsenlosenko commented Mar 17, 2023 • edited by github-actions bot

Build Failed

lazebnyi commented Apr 3, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 4, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 6, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 6, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 7, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 11, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 25, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 25, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 25, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 26, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 26, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented Apr 28, 2023 • edited by github-actions bot

arsenlosenko commented Apr 28, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented May 1, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented May 3, 2023 • edited by github-actions bot

Build Failed

arsenlosenko commented May 3, 2023 • edited by github-actions bot

Build Passed

arsenlosenko commented May 3, 2023 • edited by github-actions bot

arsenlosenko commented Feb 14, 2023 •

edited

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 3, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 4, 2023 •

edited by github-actions bot

arsenlosenko commented Mar 17, 2023 •

edited by github-actions bot

lazebnyi commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 6, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 6, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 7, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 11, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 25, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 25, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 25, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 26, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 28, 2023 •

edited by github-actions bot

arsenlosenko commented Apr 28, 2023 •

edited by github-actions bot

arsenlosenko commented May 1, 2023 •

edited by github-actions bot

arsenlosenko commented May 3, 2023 •

edited by github-actions bot

arsenlosenko commented May 3, 2023 •

edited by github-actions bot

arsenlosenko commented May 3, 2023 •

edited by github-actions bot