Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Facebook-Marketing: updated facebook_business==16.0.0 #23003

Merged
merged 10 commits into from
Feb 27, 2023
Merged

Source Facebook-Marketing: updated facebook_business==16.0.0 #23003

merged 10 commits into from
Feb 27, 2023

Conversation

darynaishchenko
Copy link
Collaborator

on-call #22549

@darynaishchenko darynaishchenko self-assigned this Feb 14, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Feb 14, 2023
@darynaishchenko
Copy link
Collaborator Author

/test connector=connectors/source-facebook-marketing

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Feb 14, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4175087614
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4175087614
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             24      0   100%
source_facebook_marketing/streams/common.py                    44      0   100%
source_facebook_marketing/streams/async_job.py                217      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              41      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/streams/base_insight_streams.py     145     16    89%
source_facebook_marketing/source.py                            58      7    88%
source_facebook_marketing/streams/base_streams.py             143     32    78%
source_facebook_marketing/streams/streams.py                  123     28    77%
-------------------------------------------------------------------------------
TOTAL                                                         973     95    90%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/spec.py                              41      1    98%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/base_streams.py             143     28    80%
source_facebook_marketing/streams/common.py                    44     16    64%
source_facebook_marketing/utils.py                             24      9    62%
source_facebook_marketing/source.py                            58     22    62%
source_facebook_marketing/streams/streams.py                  123     48    61%
source_facebook_marketing/streams/base_insight_streams.py     145     64    56%
source_facebook_marketing/streams/async_job.py                217    136    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                         973    396    59%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1711    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 2284.69s (0:38:04) ==================

@darynaishchenko darynaishchenko temporarily deployed to more-secrets February 14, 2023 16:20 — with GitHub Actions Inactive
@darynaishchenko darynaishchenko temporarily deployed to more-secrets February 14, 2023 16:20 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.66% ❌

@darynaishchenko darynaishchenko linked an issue Feb 15, 2023 that may be closed by this pull request
Source Facebook Marketing - failing asking for upgrade to v16 #22549
Closed
maxi297
maxi297 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

airbyte-integrations/connectors/source-facebook-marketing/acceptance-test-config.yml
@@ -53,3 +53,4 @@ acceptance_tests:
full_refresh:
tests:
- config_path: "secrets/config.json"
timeout_seconds: 2400
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why was this added?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes it fails with timeout

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Feb 23, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/4250716460


Connector Did it publish? Were definitions generated?
connectors/source-facebook-marketing ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Feb 27, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/4281904359


Connector Did it publish? Were definitions generated?

@darynaishchenko darynaishchenko merged commit 648634c into master Feb 27, 2023
@darynaishchenko darynaishchenko deleted the daryna/source-facebook-marketing/upgrade-fb-to-v16 branch February 27, 2023 17:29
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
@darynaishchenko @lazebnyi
@octavia-squidington-iii @danielduckworth
Source Facebook-Marketing: updated facebook_business==16.0.0 (airbyte…
0cf3b62 
…hq#23003)

* updated facebook_business==16.0.0

* added changelog

* added allowedHosts

* auto-bump connector version

* Automated Change

---------

Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxi297 maxi297 maxi297 approved these changes

@bazarnov bazarnov bazarnov approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees

@darynaishchenko darynaishchenko

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Facebook Marketing - failing asking for upgrade to v16
5 participants
@darynaishchenko @maxi297 @bazarnov @lazebnyi @octavia-squidington-iii