-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Chargebee: enable high
strictness
#23207
Conversation
/test connector=connectors/source-chargebee
Build FailedTest summary info:
|
Backing up myself : need to publish before merging! |
Airbyte Code Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 on strictness, allowed_hosts, and expected records.
However, this might be a breaking change and should be a major semver bump then?
airbyte-integrations/connectors/source-chargebee/acceptance-test-config.yml
Show resolved
Hide resolved
"name": "Item", | ||
"name": "Event", | ||
"type": "object", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change? The stream name has changed maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is not breaking change, since the schema types are in place.
@evantahler I agree, however the migration to Low Code is a change even more breaking, so would like this one to be minor if you don't mind. The Chargebee would be migrated soon next week, I believe. Let's keep this one as is. |
I think I disagree - if there's a chance this can be released to users and it contains a breaking change, this should be |
I'm not going to start the Low Code soon but @artem1205. I'm just helping the ChargeBee source to have the high strictness level of CAT. @artem1205 could you please chime in and explain what's going on with the versioning for the |
/test connector=connectors/source-chargebee
Build PassedTest summary info:
|
/test connector=connectors/source-chargebee
Build PassedTest summary info:
|
/test connector=connectors/source-chargebee
Build PassedTest summary info:
|
/test connector=connectors/source-chargebee
Build PassedTest summary info:
|
I've accidentally published 0.2.0 version in #21688, but have not merged it yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see! There's a versioning issue happening. I'll 👍 then assuming users won't see this version (not published), and we will soon be on the 2x version with low-code
/test connector=connectors/source-chargebee
Build PassedTest summary info:
|
/test connector=connectors/source-chargebee
Build PassedTest summary info:
|
/publish connector=connectors/source-chargebee
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Resolving: #19038
🚨 User Impact 🚨
There are changes applied to the schemas, in order to get rid of
enum
for each schema, causing validation errors, once the response comes with something different than what is defined inside ofenum
.Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here