New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉Source MailChimp: New Stream Automations #23290
Conversation
@YowanR could you please assign anyone for review |
@btkcodedev Please make sure to run |
This comment was marked as outdated.
This comment was marked as outdated.
/test connector=connectors/source-mailchimp
Build FailedTest summary info:
|
@natalyjazzviolin Thanks for the comments and build, |
Ready for review :) |
@natalyjazzviolin Bump Here :) |
@natalyjazzviolin @sh4sh @marcosmarxm @YowanR |
The Docker version is set to 5.0 as the older version 3.5 was a stream update so considering it as a minor update rather than a patch, |
Sorry @btkcodedev for the delay to review the contribution. @airbytehq/community-assistance-dri will review during this week. |
airbyte-integrations/connectors/source-mailchimp/source_mailchimp/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mailchimp/source_mailchimp/streams.py
Show resolved
Hide resolved
Hey thanks for the contribution and apologies for the delay! I'll be the DRI responsible for reviewing this and getting it across the finish line. We currently have a backlog of about a dozen PRs, but just wanted to let you know that this PR has been added to the queue and I'll be trying my best to get to this as soon as possible. Thanks for the contribution and for being patient :) |
Thanks, It is ready for review, |
7a312f3
to
e265487
Compare
e9d3f7d
to
0a793c7
Compare
/test connector=connectors/source-mailchimp
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @btkcodedev I requested to the connector team to made the final review of the contribution. Hope to publish during the week.
Thanks @marcosmarxm for update |
Thanks @arsenlosenko for approving the PR |
/publish connector=connectors/source-mailchimp
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* bump connector version * Source: MailChimp, New Stream Automations * fix: Schema error fix * Fixes formatting. * fix: Fixed acceptance test schema errors * fix: Update schema, update dockerlabel * refactor: Update docs * refactor: Update DockerVersionTag * fix: Update EOF and configured catalog * fix: Schema, Update docs * fix: Schema on catalog * fix: update DocketVersionTag * fix: schema, update docs, bump docker version * fix: spec, update doc in streams.py * fix: schema compatability for null * update connector version to 0.4.0 * Update Dockerfile * recreate source spec * restore source spec form main * rollback source spec from main * source spec * run gradle config seed * fix schema and remove unused code * fix docs * bump connector seed file versino * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: nataly <nataly@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
What
Closes #17024
Enhancement
Adds a new stream:
Recommended reading order
source_mailchimp/source.py
source_mailchimp/streams.py
source_mailchimp/schemas/automations.json
🚨 User Impact 🚨
No breaking changes
Pre-merge Checklist
Updating a connector
Community member or Airbyter [Yes]
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.For the reviewer: