Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source MailChimp: New Stream Automations #23290

Merged
merged 27 commits into from Apr 24, 2023

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented Feb 21, 2023

What

Closes #17024

Enhancement

Adds a new stream:

  • Automations (Incremental)

Recommended reading order

  1. source_mailchimp/source.py
  2. source_mailchimp/streams.py
  3. source_mailchimp/schemas/automations.json

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter [Yes]

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Documentation that references the generator is updated as needed

For the reviewer:

  • New stream is working in my local system and all acceptance test passing
  • Please review & test it on the prod

@btkcodedev
Copy link
Collaborator Author

@YowanR could you please assign anyone for review

@natalyjazzviolin
Copy link
Contributor

@btkcodedev Please make sure to run ./gradlew --no-daemon :airbyte-integrations:connectors:source-mailchimp:airbytePythonFormat to fix formatting errors.

@natalyjazzviolin

This comment was marked as outdated.

@natalyjazzviolin
Copy link
Contributor

natalyjazzviolin commented Feb 24, 2023

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4266365963
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4266365963
🐛 https://gradle.com/s/pr6nvlsw6b4vg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
FAILED test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1]
FAILED test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs2]
FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs1]
FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs2]
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
======================== 10 failed, 52 passed in 45.52s ========================

@btkcodedev
Copy link
Collaborator Author

@natalyjazzviolin Thanks for the comments and build,
Primary keys, and cursor fields, all are updated and schema fixed.
Acceptance test is passing in local
Please continue the further review.

@btkcodedev
Copy link
Collaborator Author

Ready for review :)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 16, 2023
@btkcodedev
Copy link
Collaborator Author

@natalyjazzviolin Bump Here :)

@btkcodedev
Copy link
Collaborator Author

@natalyjazzviolin @sh4sh @marcosmarxm @YowanR
The PR is ready for review,
Please could anyone run the test command :)

@btkcodedev
Copy link
Collaborator Author

The Docker version is set to 5.0 as the older version 3.5 was a stream update so considering it as a minor update rather than a patch,
Old -> 4.0 and now it's 5.0

@marcosmarxm marcosmarxm added the contributor-program PRs submitted through the contributor program. label Apr 2, 2023
@marcosmarxm marcosmarxm requested review from a team and removed request for natalyjazzviolin April 2, 2023 10:16
@marcosmarxm
Copy link
Member

Sorry @btkcodedev for the delay to review the contribution. @airbytehq/community-assistance-dri will review during this week.

@sajarin
Copy link
Contributor

sajarin commented Apr 5, 2023

Hey thanks for the contribution and apologies for the delay!

I'll be the DRI responsible for reviewing this and getting it across the finish line. We currently have a backlog of about a dozen PRs, but just wanted to let you know that this PR has been added to the queue and I'll be trying my best to get to this as soon as possible.

Thanks for the contribution and for being patient :)

@btkcodedev
Copy link
Collaborator Author

Thanks, It is ready for review,
Please forward

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 11, 2023

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4671537838
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4671537838
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_mailchimp/__init__.py       2      0   100%
source_mailchimp/source.py        46      1    98%
source_mailchimp/streams.py      131     10    92%
--------------------------------------------------
TOTAL                            179     11    94%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
=================== 64 passed, 1 skipped in 71.95s (0:01:11) ===================

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @btkcodedev I requested to the connector team to made the final review of the contribution. Hope to publish during the week.

@btkcodedev
Copy link
Collaborator Author

Thanks @marcosmarxm for update

@btkcodedev
Copy link
Collaborator Author

Thanks @arsenlosenko for approving the PR

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 24, 2023

/publish connector=connectors/source-mailchimp

🕑 Publishing the following connectors:
connectors/source-mailchimp
https://github.com/airbytehq/airbyte/actions/runs/4789047376


Connector Version Did it publish? Were definitions generated?
connectors/source-mailchimp 0.4.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm merged commit f6bd910 into airbytehq:master Apr 24, 2023
37 of 44 checks passed
marcosmarxm added a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* bump connector version

* Source: MailChimp, New Stream Automations

* fix: Schema error fix

* Fixes formatting.

* fix: Fixed acceptance test schema errors

* fix: Update schema, update dockerlabel

* refactor: Update docs

* refactor: Update DockerVersionTag

* fix: Update EOF and configured catalog

* fix: Schema, Update docs

* fix: Schema on catalog

* fix: update DocketVersionTag

* fix: schema, update docs, bump docker version

* fix: spec, update doc in streams.py

* fix: schema compatability for null

* update connector version to 0.4.0

* Update Dockerfile

* recreate source spec

* restore source spec form main

* rollback source spec from main

* source spec

* run gradle config seed

* fix schema and remove unused code

* fix docs

* bump connector seed file versino

* auto-bump connector version

---------

Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Co-authored-by: nataly <nataly@airbyte.io>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/mailchimp contributor-program PRs submitted through the contributor program. ga-connector-change gl-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Mailchimp: new stream Automations
7 participants