🎉 Source Google Sheets - skip non-grid sheets #23292

midavadim · 2023-02-21T17:41:58Z

What

was able to to reproduce error - problem happens during google sheets with tab with imported datasource.

How

Solution - skip non grid sheets.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

CLAassistant · 2023-02-21T17:42:03Z

All committers have signed the CLA.

midavadim · 2023-02-21T17:46:00Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4235423940
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4235423940
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
google_sheets_source/models/spreadsheet_values.py      12      0   100%
google_sheets_source/models/spreadsheet.py             34      0   100%
google_sheets_source/models/__init__.py                 2      0   100%
google_sheets_source/__init__.py                        2      0   100%
google_sheets_source/helpers.py                       139     26    81%
google_sheets_source/client.py                         23      6    74%
google_sheets_source/google_sheets_source.py          107     85    21%
-----------------------------------------------------------------------
TOTAL                                                 319    117    63%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       142      5    96%   87, 93, 242, 246-247
	 connector_acceptance_test/conftest.py                     220    102    54%   37, 43-45, 50, 55, 60, 83, 89, 95-97, 116, 121-123, 129-131, 137-138, 143-144, 149, 160, 169-178, 184-189, 204, 228, 259, 265, 273-281, 289-302, 310-323, 328-334, 341-352, 359-375
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       134     33    75%   30-33, 53-54, 57-61, 64-65, 80-82, 85-87, 90-92, 95-97, 100-102, 132-133, 167-169, 216
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1716    348    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental sync are not supported on this connector
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 34 passed, 3 skipped in 226.10s (0:03:46) ===================

lazebnyi

LGTM! After successfully passed CI we can move next.

maxi297

Conditional approval: should we have unit tests for this? I would have expected a test to fail and have to be updated following a change like that

airbyte-integrations/connectors/source-google-sheets/google_sheets_source/helpers.py

…ith-connected-datasource # Conflicts: # airbyte-integrations/connectors/source-google-sheets/Dockerfile # docs/integrations/sources/google-sheets.md

midavadim · 2023-02-27T15:16:14Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4283896928
❌ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4283896928
🐛 https://gradle.com/s/smc7lyxl7hsdu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs2] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs3] - docker.errors.Cont...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestBasicRead::test_airbyte_trace_message_on_failure[inputs0]
ERROR test_core.py::TestSpec::test_config_match_spec[inputs0] - docker.errors...
ERROR test_core.py::TestSpec::test_match_expected[inputs0] - docker.errors.Co...
ERROR test_core.py::TestSpec::test_docker_env[inputs0] - docker.errors.Contai...
ERROR test_core.py::TestSpec::test_enum_usage[inputs0] - docker.errors.Contai...
ERROR test_core.py::TestSpec::test_oneof_usage[inputs0] - docker.errors.Conta...
ERROR test_core.py::TestSpec::test_secret_is_properly_marked[inputs0] - docke...
ERROR test_core.py::TestSpec::test_defined_refs_exist_in_json_spec_file[inputs0]
ERROR test_core.py::TestSpec::test_oauth_flow_parameters[inputs0] - docker.er...
ERROR test_core.py::TestSpec::test_backward_compatibility[inputs0] - docker.e...
ERROR test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - d...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental sync are not supported on this connector
============= 6 failed, 10 passed, 1 skipped, 20 errors in 32.38s ==============

midavadim · 2023-02-27T15:57:05Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4284277759
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/4284277759
Python tests coverage:

Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
source_google_sheets/models/spreadsheet_values.py      12      0   100%
source_google_sheets/models/spreadsheet.py             34      0   100%
source_google_sheets/models/__init__.py                 2      0   100%
source_google_sheets/__init__.py                        2      0   100%
source_google_sheets/utils.py                          23      1    96%
source_google_sheets/helpers.py                       145     27    81%
source_google_sheets/client.py                         23      6    74%
source_google_sheets/source.py                        115     91    21%
-----------------------------------------------------------------------
TOTAL                                                 356    125    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental sync are not supported on this connector
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 34 passed, 3 skipped in 138.78s (0:02:18) ===================

…ith-connected-datasource

midavadim · 2023-02-27T16:22:09Z

/publish connector=connectors/source-google-sheets

🕑 Publishing the following connectors:
connectors/source-google-sheets
https://github.com/airbytehq/airbyte/actions/runs/4284518894

Connector	Did it publish?	Were definitions generated?
connectors/source-google-sheets	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* skip non grid sheets * added PR number to docs * fixed Dockerfile * fix doc * fix doc * updated seed file * updated docs * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

skip non grid sheets

4d697a9

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-sheets labels Feb 21, 2023

midavadim requested a review from lazebnyi February 21, 2023 17:43

midavadim linked an issue Feb 21, 2023 that may be closed by this pull request

Source Google Sheets: sync fails when google sheets has a Data Connector to Big Query #17100

Closed

added PR number to docs

a655b3a

lazebnyi approved these changes Feb 22, 2023

View reviewed changes

midavadim requested a review from maxi297 February 23, 2023 12:44

maxi297 approved these changes Feb 27, 2023

View reviewed changes

airbyte-integrations/connectors/source-google-sheets/google_sheets_source/helpers.py Outdated Show resolved Hide resolved

midavadim added 5 commits February 27, 2023 17:02

Merge branch 'master' into midavadim/17100-google-sheets-handle-tab-w…

4632ffc

…ith-connected-datasource # Conflicts: # airbyte-integrations/connectors/source-google-sheets/Dockerfile # docs/integrations/sources/google-sheets.md

fixed Dockerfile

c369b9c

fix doc

b8b20d9

fix doc

e5cae54

updated seed file

af03d3a

updated docs

2f0206e

Merge branch 'master' into midavadim/17100-google-sheets-handle-tab-w…

17c2f5e

…ith-connected-datasource

auto-bump connector version

7aa07c0

midavadim merged commit 259b8a2 into master Feb 27, 2023

midavadim deleted the midavadim/17100-google-sheets-handle-tab-with-connected-datasource branch February 27, 2023 17:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Google Sheets - skip non-grid sheets #23292

🎉 Source Google Sheets - skip non-grid sheets #23292

midavadim commented Feb 21, 2023 •

edited

CLAassistant commented Feb 21, 2023 •

edited

midavadim commented Feb 21, 2023 •

edited by github-actions bot

lazebnyi left a comment

maxi297 left a comment

midavadim commented Feb 27, 2023 •

edited by github-actions bot

midavadim commented Feb 27, 2023 •

edited by github-actions bot

midavadim commented Feb 27, 2023 •

edited by github-actions bot

🎉 Source Google Sheets - skip non-grid sheets #23292

🎉 Source Google Sheets - skip non-grid sheets #23292

Conversation

midavadim commented Feb 21, 2023 • edited

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Feb 21, 2023 • edited

midavadim commented Feb 21, 2023 • edited by github-actions bot

Build Passed

lazebnyi left a comment

Choose a reason for hiding this comment

maxi297 left a comment

Choose a reason for hiding this comment

midavadim commented Feb 27, 2023 • edited by github-actions bot

Build Failed

midavadim commented Feb 27, 2023 • edited by github-actions bot

Build Passed

midavadim commented Feb 27, 2023 • edited by github-actions bot

midavadim commented Feb 21, 2023 •

edited

CLAassistant commented Feb 21, 2023 •

edited

midavadim commented Feb 21, 2023 •

edited by github-actions bot

midavadim commented Feb 27, 2023 •

edited by github-actions bot

midavadim commented Feb 27, 2023 •

edited by github-actions bot

midavadim commented Feb 27, 2023 •

edited by github-actions bot