Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Stripe: Add customer tax ids to invoices stream #23389

Conversation

mrhallak
Copy link
Contributor

@mrhallak mrhallak commented Feb 23, 2023

What

The change solves this issue where the customer_tax_ids field is not showing on the UI nor the final table.

How

I added the field to the configured catalog and schema.

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 23, 2023
@Previatto
Copy link

I believe this might be the correct issue #23388, not the one linked.

@mrhallak
Copy link
Contributor Author

mrhallak commented Apr 5, 2023

I believe this might be the correct issue #23388, not the one linked.

Good catch, thank you

@archangelic
Copy link
Contributor

archangelic commented Apr 12, 2023

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4681875768
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4681875768
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_stripe/source.py                     22      0   100%
source_stripe/__init__.py                    2      0   100%
source_stripe/streams.py                   319     33    90%
source_stripe/availability_strategy.py      19      2    89%
------------------------------------------------------------
TOTAL                                      362     35    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 39 passed, 1 skipped in 214.21s (0:03:34) ===================

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 24, 2023

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4789420871
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4789420871
Python tests coverage:

Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_stripe/source.py                     22      0   100%
source_stripe/__init__.py                    2      0   100%
source_stripe/streams.py                   330     34    90%
source_stripe/availability_strategy.py      19      2    89%
------------------------------------------------------------
TOTAL                                      373     36    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 39 passed, 1 skipped in 254.76s (0:04:14) ===================

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 24, 2023

/publish connector=connectors/source-stripe

🕑 Publishing the following connectors:
connectors/source-stripe
https://github.com/airbytehq/airbyte/actions/runs/4789886879


Connector Version Did it publish? Were definitions generated?
connectors/source-stripe 3.4.1

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm merged commit f9fe9fe into airbytehq:master Apr 24, 2023
31 of 37 checks passed
marcosmarxm added a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…3389)

* Add customer tax ids to invoices

* Update docs

* Update source_specs.yaml

* Update versions

* Bump version

* Update source_definitions.yaml

* Update source_specs.yaml

* fix source_definitions

* formatting changes

* fix schema and add expected records

* fix expected records

* auto-bump connector version

---------

Co-authored-by: Mal Hancock <mallory@archangelic.space>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants