-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Stripe: Add customer tax ids to invoices stream #23389
🐛 Source Stripe: Add customer tax ids to invoices stream #23389
Conversation
I believe this might be the correct issue #23388, not the one linked. |
Good catch, thank you |
/test connector=connectors/source-stripe
Build PassedTest summary info:
|
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/invoices.json
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-stripe
Build PassedTest summary info:
|
/publish connector=connectors/source-stripe
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…3389) * Add customer tax ids to invoices * Update docs * Update source_specs.yaml * Update versions * Bump version * Update source_definitions.yaml * Update source_specs.yaml * fix source_definitions * formatting changes * fix schema and add expected records * fix expected records * auto-bump connector version --------- Co-authored-by: Mal Hancock <mallory@archangelic.space> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
The change solves this issue where the
customer_tax_ids
field is not showing on the UI nor the final table.How
I added the field to the configured catalog and schema.
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here