New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect documentation url. #2342
Fix incorrect documentation url. #2342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
For this change to be shipped to Airbyte users we need to bump the connector version and publish it. To do that do the following:
- Bump the version of the connector inside the Dockerfile in its module root
- Bump the version of the connector in the source_definitions yaml and the corresponding generated JSON
- Push your changes to this PR (you should have bumped the version in 3 different locations at this point)
- Comment on this PR with "/publish connector=connectors/source-http". This will launch a workflow that runs integration tests and publishes the new image version if they succeed.
- Merge!
/publish connector=connectors/source-http
|
i mistyped the name in my comment, the full name is |
so you'll need |
/publish connector=connectors/source-http-request
|
I checked the logs, spent some time scratching my head and decided to defer to today since it was late my side - I am a dumbass for not checking the command itself heh |
What
Bad documentation url.
How
Update to the right url.
Pre-merge Checklist