Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect documentation url. #2342

Merged

Conversation

davinchia
Copy link
Contributor

What

Bad documentation url.

How

Update to the right url.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

For this change to be shipped to Airbyte users we need to bump the connector version and publish it. To do that do the following:

  1. Bump the version of the connector inside the Dockerfile in its module root
  2. Bump the version of the connector in the source_definitions yaml and the corresponding generated JSON
  3. Push your changes to this PR (you should have bumped the version in 3 different locations at this point)
  4. Comment on this PR with "/publish connector=connectors/source-http". This will launch a workflow that runs integration tests and publishes the new image version if they succeed.
  5. Merge!

@davinchia
Copy link
Contributor Author

davinchia commented Mar 7, 2021

/publish connector=connectors/source-http

🕑 connectors/source-http https://github.com/airbytehq/airbyte/actions/runs/629404350
❌ connectors/source-http https://github.com/airbytehq/airbyte/actions/runs/629404350
🕑 connectors/source-http https://github.com/airbytehq/airbyte/actions/runs/629404350
❌ connectors/source-http https://github.com/airbytehq/airbyte/actions/runs/629404350

@sherifnada
Copy link
Contributor

i mistyped the name in my comment, the full name is source-http-request

@sherifnada
Copy link
Contributor

so you'll need /publish connector=connectors/source-http-request

@davinchia
Copy link
Contributor Author

davinchia commented Mar 7, 2021

/publish connector=connectors/source-http-request

🕑 connectors/source-http-request https://github.com/airbytehq/airbyte/actions/runs/630620793
✅ connectors/source-http-request https://github.com/airbytehq/airbyte/actions/runs/630620793

@davinchia
Copy link
Contributor Author

I checked the logs, spent some time scratching my head and decided to defer to today since it was late my side - I am a dumbass for not checking the command itself heh

@davinchia davinchia merged commit 8d54997 into master Mar 8, 2021
@davinchia davinchia deleted the davinchia/issue-2341-http-request-bad-documentation-url branch March 8, 2021 00:11
@davinchia davinchia linked an issue Mar 8, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webapp's Http Request Source documentation link is not correct.
2 participants