Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Notion: add retry for 400 error #23437

Merged
merged 5 commits into from
Feb 25, 2023

Conversation

artem1205
Copy link
Collaborator

What

Resolving https://github.com/airbytehq/oncall/issues/1548

How

add retry for 400 error

Recommended reading order

  1. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 24, 2023
@artem1205
Copy link
Collaborator Author

artem1205 commented Feb 24, 2023

/test connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/4264257886
❌ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/4264257886
🐛 https://gradle.com/s/v265xlpmjidx6

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_streams.py::test_should_retry[HTTPStatus.BAD_REQUEST-False]
	 �[31m================== �[31m�[1m1 failed�[0m, �[32m23 passed�[0m, �[33m65 warnings�[0m�[31m in 0.77s�[0m�[31m ===================�[0m

@artem1205
Copy link
Collaborator Author

artem1205 commented Feb 24, 2023

/test connector=connectors/source-notion

🕑 connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/4264632628
✅ connectors/source-notion https://github.com/airbytehq/airbyte/actions/runs/4264632628
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_notion/__init__.py       2      0   100%
source_notion/streams.py      131      6    95%
source_notion/source.py        37      5    86%
source_notion/utils.py          9      4    56%
-----------------------------------------------
TOTAL                         179     15    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
=================== 36 passed, 2 skipped in 97.18s (0:01:37) ===================

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but hosts are crying without your attention here.

@artem1205
Copy link
Collaborator Author

artem1205 commented Feb 25, 2023

/publish connector=connectors/source-notion

🕑 Publishing the following connectors:
connectors/source-notion
https://github.com/airbytehq/airbyte/actions/runs/4269576337


Connector Did it publish? Were definitions generated?
connectors/source-notion

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205 artem1205 merged commit 2dbcd03 into master Feb 25, 2023
@artem1205 artem1205 deleted the artem1205/source-notion-OC-1548 branch February 25, 2023 11:27
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
* Source Notion: add retry for 400 error

* Source Notion: add retry for 400 error (validation_error)

* Source Notion: fix test

* Source Notion: add hosts

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/notion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants