Source Mailchimp - Add Reports stream #23464

haithem-souala · 2023-02-25T15:13:15Z

What

How

Add a new stream: Reports

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

CLAassistant · 2023-02-25T15:13:20Z

All committers have signed the CLA.

haithem-souala · 2023-02-25T17:20:09Z

/test connector=source-mailchimp

YowanR · 2023-02-25T19:28:17Z

@sh4sh @natalyjazzviolin this PR is ready for review 🙏

sajarin · 2023-03-13T15:55:25Z

/test connector=source-mailchimp

🕑 source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4406926827
❌ source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4406926827
🐛 https://gradle.com/s/q36qc7xzksh5e

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_source.py::test_streams_count - assert 4 == 3
	 �[31m================== �[31m�[1m1 failed�[0m, �[32m17 passed�[0m, �[33m59 warnings�[0m�[31m in 0.55s�[0m�[31m ===================�[0m

haithem-souala · 2023-03-13T16:25:25Z

Hey @sajarin, fixed, can you re-run the tests please?!

YowanR · 2023-03-15T01:13:52Z

Bump here @sajarin @marcosmarxm

sajarin · 2023-03-15T13:04:41Z

/test connector=source-mailchimp

🕑 source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4426613537
❌ source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4426613537
🐛 https://gradle.com/s/zjxj5tmt6agys

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
=================== 1 failed, 60 passed, 1 skipped in 56.49s ===================

marcosmarxm · 2023-03-15T16:47:58Z

/test connector=source-mailchimp

🕑 source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4428800272
❌ source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4428800272
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
=================== 61 passed, 1 skipped in 68.01s (0:01:08) ===================

marcosmarxm · 2023-03-15T17:00:03Z

/test connector=source-mailchimp

🕑 source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4428912138
✅ source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4428912138
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_mailchimp/__init__.py       2      0   100%
source_mailchimp/source.py        46      1    98%
source_mailchimp/streams.py      126      9    93%
--------------------------------------------------
TOTAL                            174     10    94%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
=================== 61 passed, 1 skipped in 69.93s (0:01:09) ===================

marcosmarxm · 2023-03-15T17:19:22Z

/publish connector=source-mailchimp

🕑 Publishing the following connectors:
source-mailchimp
https://github.com/airbytehq/airbyte/actions/runs/4429099503

Connector	Did it publish?	Were definitions generated?
source-mailchimp	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm · 2023-03-15T17:58:52Z

/publish connector=connectors/source-mailchimp

🕑 Publishing the following connectors:
connectors/source-mailchimp
https://github.com/airbytehq/airbyte/actions/runs/4429439341

Connector	Did it publish?	Were definitions generated?
connectors/source-mailchimp	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm

Thanks for the contribution @haithem-souala next time please create a specific branch to the PR

haithem-souala · 2023-03-15T18:13:43Z

Thanks for the contribution @haithem-souala next time please create a specific branch to the PR 👌

* init commit * update doc * add reports stream * Bump mailchimps connector docker image * fix tests * update abnormal stream state for report mailchimp * add mailchimp allowedHosts * run config seed files --------- Co-authored-by: Haithem Souala <haithem.souala@melting-point.fr> Co-authored-by: Haithem Souala <haithem.souala@woopit.fr>

marcosmarxm · 2023-03-15T19:27:27Z

Merged at #24112

* init commit * update doc * add reports stream * Bump mailchimps connector docker image * fix tests * update abnormal stream state for report mailchimp * add mailchimp allowedHosts * run config seed files --------- Co-authored-by: Haithem Souala <haithem.souala@melting-point.fr> Co-authored-by: Haithem Souala <haithem.souala@woopit.fr>

init commit

9a6d930

octavia-squidington-iii added area/connectors Connector related issues connectors/source/mailchimp labels Feb 25, 2023

update doc

3ff2a77

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 25, 2023

add reports stream

1c2333b

haithem-souala changed the title ~~[WIP] Source Mailchimp - Add Reports stream~~ Source Mailchimp - Add Reports stream Feb 25, 2023

Bump mailchimps connector docker image

f0a8e7a

YowanR requested review from sh4sh and natalyjazzviolin February 25, 2023 19:27

Merge branch 'airbytehq:master' into master

414ef59

YowanR requested a review from sajarin March 7, 2023 20:21

Merge branch 'airbytehq:master' into master

5843c4c

fix tests

7eb800b

update abnormal stream state for report mailchimp

c159ec9

Merge branch 'master' into master

bbcdf05

marcosmarxm mentioned this pull request Mar 15, 2023

Publish Source Mailchimp - Add Reports stream #23464 #24105

Closed

37 tasks

add mailchimp allowedHosts

ab6fb0b

marcosmarxm approved these changes Mar 15, 2023

View reviewed changes

marcosmarxm mentioned this pull request Mar 15, 2023

Source Mailchimp - Add Reports stream #23464 #24112

Merged

37 tasks

marcosmarxm closed this Mar 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Mailchimp - Add Reports stream #23464

Source Mailchimp - Add Reports stream #23464

haithem-souala commented Feb 25, 2023 •

edited

Loading

CLAassistant commented Feb 25, 2023 •

edited

Loading

haithem-souala commented Feb 25, 2023

YowanR commented Feb 25, 2023

sajarin commented Mar 13, 2023 •

edited by github-actions bot

Loading

haithem-souala commented Mar 13, 2023 •

edited

Loading

YowanR commented Mar 15, 2023

sajarin commented Mar 15, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 15, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 15, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 15, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 15, 2023 •

edited by github-actions bot

Loading

marcosmarxm left a comment

haithem-souala commented Mar 15, 2023

marcosmarxm commented Mar 15, 2023

Source Mailchimp - Add Reports stream #23464

Source Mailchimp - Add Reports stream #23464

Conversation

haithem-souala commented Feb 25, 2023 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Feb 25, 2023 • edited Loading

haithem-souala commented Feb 25, 2023

YowanR commented Feb 25, 2023

sajarin commented Mar 13, 2023 • edited by github-actions bot Loading

Build Failed

haithem-souala commented Mar 13, 2023 • edited Loading

YowanR commented Mar 15, 2023

sajarin commented Mar 15, 2023 • edited by github-actions bot Loading

Build Failed

marcosmarxm commented Mar 15, 2023 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Mar 15, 2023 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Mar 15, 2023 • edited by github-actions bot Loading

marcosmarxm commented Mar 15, 2023 • edited by github-actions bot Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

haithem-souala commented Mar 15, 2023

marcosmarxm commented Mar 15, 2023

haithem-souala commented Feb 25, 2023 •

edited

Loading

CLAassistant commented Feb 25, 2023 •

edited

Loading

sajarin commented Mar 13, 2023 •

edited by github-actions bot

Loading

haithem-souala commented Mar 13, 2023 •

edited

Loading

sajarin commented Mar 15, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 15, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 15, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 15, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 15, 2023 •

edited by github-actions bot

Loading