Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document command to only build core Airbyte systems. #2351

Merged
merged 4 commits into from
Mar 9, 2021

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Mar 8, 2021

What

Since the full airbyte build takes some time, devs might want to save time and only build the core airbyte system. This functionality already exists, however is not documented anywhere.

Also take the chance to add the out directories to the .gitignore file.

How

Documenting it.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

@@ -38,6 +38,11 @@ This will build all the code and run all the unit tests.

`./gradle build` creates all the necessary artifacts \(Webapp, Jars and Docker images\) so that you can run Airbyte locally.

The `./gradlew build` builds the core Airbyte system, and all the connectors. This can take some time. To compile and build just the core systems:
```bash
export CORE_ONLY=1 && ./gradlew build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this set CORE_ONLY to true for every subsequent build command in this session too? is that the desired behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. changing to CORE_ONLY=true && ./gradlew build

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need the && , running CORE_ONLY=true ./gradlew build sets the env variable for that command only

@davinchia davinchia merged commit 80984d0 into master Mar 9, 2021
@davinchia davinchia deleted the davinchia/add-core-only-build-command branch March 9, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants