Source Pipedrive: promote to cloud #23539

grubberr · 2023-02-28T10:20:25Z

What

acceptance-test fixed
QueryStringTokenAuthenticator new auth class added
Fix schema for "activities"
"check" command works if empty "deals"
improved validation of replication_start_date

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-28T10:22:11Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4291918436
❌ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4291918436
🐛 https://gradle.com/s/uon2ybovxs4j4

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_source.py::test_read - pydantic.error_wrappers.Validat...
	 �[31m================== �[31m�[1m1 failed�[0m, �[32m21 passed�[0m, �[33m61 warnings�[0m�[31m in 1.00s�[0m�[31m ===================�[0m

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-28T10:43:25Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4292096531
❌ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4292096531
🐛 https://gradle.com/s/bbvkbqs3zu4qy

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: as...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:516: Backward compatibility tests are disabled for version 0.1.13.
============== 1 failed, 37 passed, 1 skipped in 66.35s (0:01:06) ==============

grubberr · 2023-02-28T11:29:56Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4292483176
❌ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4292483176
🐛 https://gradle.com/s/kxvt6ajacna6m

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream users...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:516: Backward compatibility tests are disabled for version 0.1.13.
============== 1 failed, 37 passed, 1 skipped in 63.65s (0:01:03) ==============

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-28T14:53:25Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4294255368
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4294255368
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pipedrive/__init__.py       2      0   100%
source_pipedrive/source.py        36      2    94%
source_pipedrive/streams.py       77      8    90%
--------------------------------------------------
TOTAL                            115     10    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.13.
=================== 38 passed, 1 skipped in 84.14s (0:01:24) ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-02-28T20:04:05Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4296929265
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4296929265
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pipedrive/auth.py           8      0   100%
source_pipedrive/__init__.py       2      0   100%
source_pipedrive/source.py        32      1    97%
source_pipedrive/streams.py       71      7    90%
--------------------------------------------------
TOTAL                            113      8    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.13.
=================== 38 passed, 1 skipped in 84.51s (0:01:24) ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-03-01T07:34:06Z

/test connector=connectors/source-pipedrive

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

This reverts commit 3dd6fd4.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-03-01T09:10:38Z

/test connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4301874203
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/4301874203
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_pipedrive/auth.py           8      0   100%
source_pipedrive/__init__.py       2      0   100%
source_pipedrive/source.py        37      2    95%
source_pipedrive/streams.py       73      8    89%
--------------------------------------------------
TOTAL                            120     10    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.13.
=================== 38 passed, 1 skipped in 69.71s (0:01:09) ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-03-01T13:23:34Z

/publish connector=connectors/source-pipedrive

🕑 Publishing the following connectors:
connectors/source-pipedrive
https://github.com/airbytehq/airbyte/actions/runs/4303997879

Connector	Did it publish?	Were definitions generated?
connectors/source-pipedrive	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

fix schema for activities, SAT high strictness

f4140b1

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added area/connectors Connector related issues connectors/source/pipedrive labels Feb 28, 2023

grubberr linked an issue Feb 28, 2023 that may be closed by this pull request

[EPIC] Source Pipedrive: Enable in Cloud and Certify to Beta #23474

Closed

grubberr self-assigned this Feb 28, 2023

pipedrive.md - fixed, unit_tests - fixed

c32f635

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 28, 2023

grubberr added 2 commits February 28, 2023 14:49

Merge branch 'master' into grubberr/23474-source-pipedrive

9426f21

ignored_fields added

0f139aa

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 2 commits February 28, 2023 15:42

"format": "date-time" - added

e3acb06

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

QueryStringTokenAuthenticator added

22e7cf4

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

"format": "date-time" added

3dd6fd4

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 3 commits March 1, 2023 08:45

_validate_and_transform added

ddd7480

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Revert ""format": "date-time" added"

5fdc154

This reverts commit 3dd6fd4.

small refactoring

ece6f30

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 2 commits March 1, 2023 09:11

Merge branch 'master' into grubberr/23474-source-pipedrive

9199cf7

pipedrive.md updated

7e2f71c

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr changed the title ~~Source Pipedrive: fix schema for activities stream~~ Source Pipedrive: promote to cloud Mar 1, 2023

allowedHosts added

a2a7992

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

This was referenced Mar 1, 2023

Source Pipedrive: Connection check fails if you don't have any deals #21944

Closed

Source Pipedrive: Mark datefields in properly as dates #22761

Closed

grubberr requested review from lazebnyi and davydov-d March 1, 2023 10:31

arsenlosenko mentioned this pull request Mar 1, 2023

Source Pipedrive: Mark datefields in spec as dates #22914

Closed

37 tasks

lazebnyi approved these changes Mar 1, 2023

View reviewed changes

octavia-squidington-iii and others added 3 commits March 1, 2023 13:36

auto-bump connector version

549d866

Merge branch 'master' into grubberr/23474-source-pipedrive

a5ed13f

Merge branch 'master' into grubberr/23474-source-pipedrive

e010295

grubberr merged commit bd6e743 into master Mar 1, 2023

grubberr deleted the grubberr/23474-source-pipedrive branch March 1, 2023 17:35

danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023

Source Pipedrive: promote to cloud (airbytehq#23539)

90d645a

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

sajarin mentioned this pull request Apr 19, 2023

Source Pipedrive: fix connection check failure with no deals #22051

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Pipedrive: promote to cloud #23539

Source Pipedrive: promote to cloud #23539

grubberr commented Feb 28, 2023 •

edited

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Mar 1, 2023

grubberr commented Mar 1, 2023 •

edited by github-actions bot

grubberr commented Mar 1, 2023 •

edited by github-actions bot

Source Pipedrive: promote to cloud #23539

Source Pipedrive: promote to cloud #23539

Conversation

grubberr commented Feb 28, 2023 • edited

What

Pre-merge Checklist

Community member or Airbyter

Airbyter

grubberr commented Feb 28, 2023 • edited by github-actions bot

Build Failed

grubberr commented Feb 28, 2023 • edited by github-actions bot

Build Failed

grubberr commented Feb 28, 2023 • edited by github-actions bot

Build Failed

grubberr commented Feb 28, 2023 • edited by github-actions bot

Build Passed

grubberr commented Feb 28, 2023 • edited by github-actions bot

Build Passed

grubberr commented Mar 1, 2023

grubberr commented Mar 1, 2023 • edited by github-actions bot

Build Passed

grubberr commented Mar 1, 2023 • edited by github-actions bot

grubberr commented Feb 28, 2023 •

edited

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Feb 28, 2023 •

edited by github-actions bot

grubberr commented Mar 1, 2023 •

edited by github-actions bot

grubberr commented Mar 1, 2023 •

edited by github-actions bot