Postgres Source Fixed JSONB array mapping #23608

VitaliiMaltsev · 2023-03-01T09:49:28Z

What

Issue https://github.com/airbytehq/oncall/issues/1570

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

VitaliiMaltsev · 2023-03-01T09:50:58Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4302214178
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4302214178
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
=================== 62 passed, 5 skipped in 85.10s (0:01:25) ===================

github-actions · 2023-03-01T09:52:18Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (3)

Connector	Version	Changelog	Publish
`source-alloydb`	`1.0.49`	✅	✅
`source-alloydb-strict-encrypt`	`1.0.49`	🔵 (ignored)	🔵 (ignored)
`source-postgres-strict-encrypt`	`1.0.51`	🔵 (ignored)	🔵 (ignored)

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

subodh1810

Can you add tests for this

subodh1810 · 2023-03-01T09:52:36Z

...postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSourceOperations.java

@@ -216,7 +216,7 @@ private void putJsonbArray(ObjectNode node, String columnName, ResultSet resultS
    final ResultSet arrayResultSet = resultSet.getArray(colIndex).getResultSet();

    while (arrayResultSet.next()) {
-      final PGobject object = getObject(arrayResultSet, colIndex, PGobject.class);
+      final PGobject object = getObject(arrayResultSet, 2, PGobject.class);


Am not sure I understand this. Why is the value hardcoded at 2?

I think you need to traverse the result set and increase the index as you go. This seems wrong

Am not sure I understand this. Why is the value hardcoded at 2?

Please take a look how all of other arrays mapping implemented (varchar array, int array, etc)
During iteration over arrays resultSet there are only 2 indexes:
index 1 - the ordinal number of the element in the array
index 2 - value

I see. Can you add a test for this.

I see. Can you add a test for this.

we already have test for jsonb[] datatype in AbstractPostgresSourceDatatypeTest. Updated it to contain more than 2 elements in array

VitaliiMaltsev · 2023-03-01T10:45:14Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4302683470
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4302683470
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
=================== 62 passed, 5 skipped in 83.72s (0:01:23) ===================

VitaliiMaltsev · 2023-03-01T12:33:25Z

/publish connector=connectors/source-postgres

VitaliiMaltsev · 2023-03-01T12:33:50Z

/publish connector=connectors/source-postgres-strict-encrypt

VitaliiMaltsev · 2023-03-01T12:47:14Z

/publish connector=connectors/source-postgres

VitaliiMaltsev · 2023-03-01T14:57:03Z

/publish connector=connectors/source-postgres

🕑 Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/4304838458

Connector	Did it publish?	Were definitions generated?
connectors/source-postgres	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

VitaliiMaltsev · 2023-03-01T15:00:54Z

/publish connector=connectors/source-postgres-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4304877489

Connector	Did it publish?	Were definitions generated?
connectors/source-postgres-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

subodh1810 · 2023-03-01T16:41:12Z

@VitaliiMaltsev tests to carry out with this PR.

Run a sync for a Postgres table with jsonb data type to a bigquery destination on (postgres version 1.0.49)
Update the postgres connector version which has your fix
Run the sync again and see if the data written in the destination is correct or not.

Please share how the data looks in destination on version 1.0.49 and with your fix

subodh1810 · 2023-03-01T16:46:21Z

@VitaliiMaltsev another set of tests to carry out with this PR.

Run a sync for a Postgres table with jsonb data type to a bigquery destination on (postgres version 1.0.49)
Update the postgres connector version which has your fix
Refresh the schema
Run the sync again and see if the data written in the destination is correct or not.

Please share how the data looks in destination on version 1.0.49 and with your fix

VitaliiMaltsev · 2023-03-01T17:26:08Z

@VitaliiMaltsev tests to carry out with this PR.

Run a sync for a Postgres table with jsonb data type to a bigquery destination on (postgres version 1.0.49)

Update the postgres connector version which has your fix

Run the sync again and see if the data written in the destination is correct or not.

Please share how the data looks in destination on version 1.0.49 and with your fix

@subodh1810 @edgao
##Test results

1.0.49 sync

_airbyte_raw_table

Normalized table

--------------------------------------------------------------------------

1.0.51 sync without schema refresh

_airbyte_raw_table

Normalized table

--------------------------------------------------------------------------

1.0.51 sync with schema refresh

_airbyte_raw_table

Normalized table

subodh1810 · 2023-03-01T17:39:05Z

@VitaliiMaltsev the normalized table for 1.0.51 without schema refresh doesnt show the data, its all null. why is that?

subodh1810 · 2023-03-01T17:42:23Z

@edgao shouldnt the datatype of normalized column after refresh be json instead of string (i am guessing we support json data type in bigquery)

subodh1810 · 2023-03-01T17:50:54Z

@VitaliiMaltsev the screenshots are difficult to follow. Can you use order by in your queries so that all the screenshots have the same ordering.

VitaliiMaltsev · 2023-03-01T17:54:56Z

@VitaliiMaltsev the normalized table for 1.0.51 without schema refresh doesnt show the data, its all null. why is that?

@subodh1810 because actual json schema changed to "test_column":{"type":"object","oneOf":[{"type":"array"},{"type":"object"},{"type":"number"},{"type":"string"},{"type":"boolean"}],"airbyte_type":"json"}}} and put all the values to the proper json nodes (see _airbyte_raw table) but normalization used the old schema "test_column":{"type":"string"} without schema refresh

VitaliiMaltsev · 2023-03-01T17:57:15Z

@VitaliiMaltsev the screenshots are difficult to follow. Can you use order by in your queries so that all the screenshots have the same ordering.

Screenshots have the same order

Postgres version
_airbyte_raw table
Normalized table schema
Normalized table values

subodh1810 · 2023-03-01T18:03:01Z

#23608 (comment)
I meant the screenshots showing the data in normalized tables. If you order btid column it will be easier to compare the screenshots side by side

subodh1810 · 2023-03-01T18:05:07Z

@VitaliiMaltsev for #23608 (comment)
but the problem is that now it becomes breaking change and unless the user refreshes the schema we are going to write null values which is bad.

subodh1810 · 2023-03-01T18:10:55Z

also I dont see the values from postgres. Can you share the table structure in postgres (\d <table_name>) and how the actual data looks in postgres

VitaliiMaltsev · 2023-03-01T18:19:02Z

also I dont see the values from postgres. Can you share the table structure in postgres (\d <table_name>) and how the actual data looks in postgres

Original Postgres Table
@subodh1810

subodh1810 · 2023-03-01T18:34:50Z

@VitaliiMaltsev
Update from a quick discussion that I and
@edgao had. The fact that the version with your changes is writing null values for jsonb columns in the destination if customers dont trigger a refresh schema (as mentioned here) is bad. We decided that the right way to go about this is to revert the original PR and publish new version so that OSS users have a fix and release of postgres is unblocked.

Once done we need to revisit the decision making on how we want to introduce jsonb change and after thorough testing with proper backward compatibility test you can again raise a new PR.

~~We will have to delete the image 1.0.51 published here and here~~

Update : Deleted the 1.0.51 tags from docker hub

subodh1810 · 2023-03-01T18:44:37Z

Update : Deleted the 1.0.51 tags from docker hub

Postgres Source Fixed JSONB array mapping

d1185f0

VitaliiMaltsev requested a review from a team as a code owner March 1, 2023 09:49

octavia-squidington-iii added area/connectors Connector related issues connectors/source/postgres labels Mar 1, 2023

VitaliiMaltsev requested review from subodh1810 and edgao March 1, 2023 09:49

VitaliiMaltsev mentioned this pull request Mar 1, 2023

Revert "Postgres Source : Support JSONB datatype" #23603

Closed

subodh1810 requested changes Mar 1, 2023

View reviewed changes

VitaliiMaltsev requested a review from subodh1810 March 1, 2023 10:15

updated jsonb array test

ac6266f

subodh1810 approved these changes Mar 1, 2023

View reviewed changes

bump version

2da5d31

octavia-squidington-iii added area/documentation Improvements or additions to documentation connectors/source/postgres-strict-encrypt labels Mar 1, 2023

auto-bump connector version

c99342e

subodh1810 mentioned this pull request Mar 1, 2023

Revert "Postgres Source : Support JSONB datatype" #23642

Merged

subodh1810 closed this Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Postgres Source Fixed JSONB array mapping #23608

Postgres Source Fixed JSONB array mapping #23608

VitaliiMaltsev commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023 •

edited by github-actions bot

github-actions bot commented Mar 1, 2023 •

edited

✅ Sources (3)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

subodh1810 left a comment

subodh1810 Mar 1, 2023

subodh1810 Mar 1, 2023

VitaliiMaltsev Mar 1, 2023

subodh1810 Mar 1, 2023

VitaliiMaltsev Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023 •

edited by github-actions bot

VitaliiMaltsev commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023 •

edited by github-actions bot

VitaliiMaltsev commented Mar 1, 2023 •

edited by github-actions bot

subodh1810 commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023 •

edited

VitaliiMaltsev commented Mar 1, 2023

subodh1810 commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023

subodh1810 commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023

subodh1810 commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023

Postgres Source Fixed JSONB array mapping #23608

Postgres Source Fixed JSONB array mapping #23608

Conversation

VitaliiMaltsev commented Mar 1, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

VitaliiMaltsev commented Mar 1, 2023 • edited by github-actions bot

Build Passed

github-actions bot commented Mar 1, 2023 • edited

Affected Connector Report

✅ Sources (3)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

subodh1810 left a comment

Choose a reason for hiding this comment

subodh1810 Mar 1, 2023

Choose a reason for hiding this comment

subodh1810 Mar 1, 2023

Choose a reason for hiding this comment

VitaliiMaltsev Mar 1, 2023

Choose a reason for hiding this comment

subodh1810 Mar 1, 2023

Choose a reason for hiding this comment

VitaliiMaltsev Mar 1, 2023

Choose a reason for hiding this comment

VitaliiMaltsev commented Mar 1, 2023 • edited by github-actions bot

Build Passed

VitaliiMaltsev commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023 • edited by github-actions bot

VitaliiMaltsev commented Mar 1, 2023 • edited by github-actions bot

subodh1810 commented Mar 1, 2023 • edited

subodh1810 commented Mar 1, 2023 • edited

VitaliiMaltsev commented Mar 1, 2023

subodh1810 commented Mar 1, 2023 • edited

subodh1810 commented Mar 1, 2023

subodh1810 commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023

subodh1810 commented Mar 1, 2023 • edited

subodh1810 commented Mar 1, 2023 • edited

subodh1810 commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023 • edited

subodh1810 commented Mar 1, 2023 • edited

subodh1810 commented Mar 1, 2023

VitaliiMaltsev commented Mar 1, 2023 •

edited by github-actions bot

github-actions bot commented Mar 1, 2023 •

edited

VitaliiMaltsev commented Mar 1, 2023 •

edited by github-actions bot

VitaliiMaltsev commented Mar 1, 2023 •

edited by github-actions bot

VitaliiMaltsev commented Mar 1, 2023 •

edited by github-actions bot

subodh1810 commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023 •

edited

VitaliiMaltsev commented Mar 1, 2023 •

edited

subodh1810 commented Mar 1, 2023 •

edited