Source Instagram: decrease give up rate #23671

darynaishchenko · 2023-03-02T15:29:45Z

Give up reason: the endpoint requires the pages_read_engagement permission. For now we haven't an access to our test account to test these permissions(add/remove). See here for more info.
Phase 1, in this PR was added info about main permissions in spec and added doc links in error message to navigate user.

darynaishchenko · 2023-03-02T15:32:59Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4315613404
❌ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4315613404
🐛 https://gradle.com/s/nmfpwrvpzuag2

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream user_...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
============= 1 failed, 34 passed, 2 skipped in 304.40s (0:05:04) ==============

darynaishchenko · 2023-03-09T17:35:24Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4377191484
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4377191484
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/source.py        31      0   100%
source_instagram/__init__.py       2      0   100%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      205     20    90%
source_instagram/api.py           59      7    88%
--------------------------------------------------
TOTAL                            333     30    91%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           59      5    92%
source_instagram/source.py        31     11    65%
source_instagram/streams.py      205     94    54%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            333    132    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 35 passed, 2 skipped in 225.34s (0:03:45) ===================

darynaishchenko · 2023-03-16T10:03:05Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4435792005
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4435792005
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/source.py        31      0   100%
source_instagram/__init__.py       2      0   100%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      215     20    91%
source_instagram/api.py           59      7    88%
--------------------------------------------------
TOTAL                            343     30    91%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           59      5    92%
source_instagram/source.py        31     11    65%
source_instagram/streams.py      215     99    54%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            343    137    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 35 passed, 2 skipped in 203.27s (0:03:23) ===================

erohmensing

One question, but 👍🏻

erohmensing · 2023-03-17T17:50:01Z

airbyte-integrations/connectors/source-instagram/source_instagram/api.py

@@ -88,7 +88,13 @@ def _find_accounts(self) -> List[Mapping[str, Any]]:
                        }
                    )
        except FacebookRequestError as exc:


Do all FacebookRequestErrors we might run into here pertain to permissions issues? Is there something more specific we could except in order to raise this specific error message in order to avoid accidentally masking other issues as permission issues?

thanks for commenting, I added improvement for this code, now we checking the error status code and if this code rated to permissions we also say about checking permission needed for our connector.

Awesome, thanks!

darynaishchenko · 2023-03-20T13:07:39Z

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4468539828
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4468539828
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/source.py        31      0   100%
source_instagram/__init__.py       2      0   100%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      215     20    91%
source_instagram/api.py           61      9    85%
--------------------------------------------------
TOTAL                            345     32    91%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           61      7    89%
source_instagram/source.py        31     11    65%
source_instagram/streams.py      215     99    54%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            345    139    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 35 passed, 2 skipped in 173.53s (0:02:53) ===================

darynaishchenko · 2023-03-20T14:40:26Z

/publish connector=connectors/source-instagram

🕑 Publishing the following connectors:
connectors/source-instagram
https://github.com/airbytehq/airbyte/actions/runs/4469455634

Connector	Did it publish?	Were definitions generated?
connectors/source-instagram	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* updated spec and added more specific error message * added change log * refactored error handling * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

updated spec and added more specific error message

efbed14

darynaishchenko self-assigned this Mar 2, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram labels Mar 2, 2023

added change log

5c5056d

Merge branch 'master' into daryna/source-instagram/decrase-give-up-rate

47bb12b

Merge branch 'master' into daryna/source-instagram/decrase-give-up-rate

d401b27

darynaishchenko assigned darynaishchenko and unassigned darynaishchenko Mar 16, 2023

darynaishchenko requested review from davydov-d and lazebnyi March 16, 2023 10:19

Merge branch 'master' into daryna/source-instagram/decrase-give-up-rate

1102e2e

lazebnyi approved these changes Mar 17, 2023

View reviewed changes

darynaishchenko requested a review from erohmensing March 17, 2023 15:55

erohmensing approved these changes Mar 17, 2023

View reviewed changes

refactored error handling

4b20f4b

darynaishchenko requested a review from erohmensing March 20, 2023 13:07

erohmensing approved these changes Mar 20, 2023

View reviewed changes

auto-bump connector version

917902c

darynaishchenko merged commit edf5b19 into master Mar 20, 2023

darynaishchenko deleted the daryna/source-instagram/decrase-give-up-rate branch March 20, 2023 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Instagram: decrease give up rate #23671

Source Instagram: decrease give up rate #23671

darynaishchenko commented Mar 2, 2023

darynaishchenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Mar 9, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Mar 16, 2023 •

edited by github-actions bot

Loading

erohmensing left a comment

erohmensing Mar 17, 2023

darynaishchenko Mar 20, 2023

erohmensing Mar 20, 2023

darynaishchenko commented Mar 20, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Mar 20, 2023 •

edited by github-actions bot

Loading

Source Instagram: decrease give up rate #23671

Source Instagram: decrease give up rate #23671

Conversation

darynaishchenko commented Mar 2, 2023

darynaishchenko commented Mar 2, 2023 • edited by github-actions bot Loading

Build Failed

darynaishchenko commented Mar 9, 2023 • edited by github-actions bot Loading

Build Passed

darynaishchenko commented Mar 16, 2023 • edited by github-actions bot Loading

Build Passed

erohmensing left a comment

Choose a reason for hiding this comment

erohmensing Mar 17, 2023

Choose a reason for hiding this comment

darynaishchenko Mar 20, 2023

Choose a reason for hiding this comment

erohmensing Mar 20, 2023

Choose a reason for hiding this comment

darynaishchenko commented Mar 20, 2023 • edited by github-actions bot Loading

Build Passed

darynaishchenko commented Mar 20, 2023 • edited by github-actions bot Loading

darynaishchenko commented Mar 2, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Mar 9, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Mar 16, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Mar 20, 2023 •

edited by github-actions bot

Loading

darynaishchenko commented Mar 20, 2023 •

edited by github-actions bot

Loading