Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Twitter: certify to beta #23749

Merged
merged 18 commits into from
Mar 7, 2023
Merged

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Mar 5, 2023

What

  • Improve title and description for api_token
  • format: date-time - added
  • twitter documentation improved

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Mar 5, 2023
@grubberr grubberr self-assigned this Mar 5, 2023
@grubberr grubberr linked an issue Mar 5, 2023 that may be closed by this pull request
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 5, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Mar 5, 2023

/test connector=connectors/source-twitter

@grubberr
Copy link
Contributor Author

grubberr commented Mar 6, 2023

/test connector=connectors/source-twitter

🕑 connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/4341104482
❌ connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/4341104482
🐛 https://gradle.com/s/3wf4qbghckcyu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_backward_compatibility[inputs0] - connect...
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
==================== 1 failed, 35 passed, 1 error in 42.05s ====================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Mar 6, 2023

/test connector=connectors/source-twitter

🕑 connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/4341290618
❌ connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/4341290618
🐛 https://gradle.com/s/rbfh4tqz5sgmi

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.1.1.
=================== 35 passed, 1 skipped, 1 error in 42.19s ====================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Mar 6, 2023

/test connector=connectors/source-twitter

🕑 connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/4341989343
✅ connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/4341989343
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
======================== 36 passed, 1 skipped in 46.71s ========================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr requested a review from lazebnyi March 6, 2023 16:00
@grubberr grubberr requested review from lazebnyi and removed request for lazebnyi March 7, 2023 15:00
@grubberr grubberr dismissed lazebnyi’s stale review March 7, 2023 15:02

I have fixed problem which was mentioned

@grubberr grubberr removed the request for review from lazebnyi March 7, 2023 15:02
@grubberr
Copy link
Contributor Author

grubberr commented Mar 7, 2023

/test connector=connectors/source-twitter

🕑 connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/4355548912
✅ connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/4355548912
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
======================== 36 passed, 1 skipped in 51.51s ========================

@grubberr
Copy link
Contributor Author

grubberr commented Mar 7, 2023

/publish connector=connectors/source-twitter

🕑 Publishing the following connectors:
connectors/source-twitter
https://github.com/airbytehq/airbyte/actions/runs/4355738127


Connector Did it publish? Were definitions generated?
connectors/source-twitter

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr grubberr merged commit 19cc7ea into master Mar 7, 2023
@grubberr grubberr deleted the grubberr/23613-source-twitter branch March 7, 2023 16:24
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/twitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Twitter: Certify to Beta
4 participants