Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Salesloft: use start_date to filter data #23828

Merged

Conversation

davydov-d
Copy link
Collaborator

What

#13659

How

The start_date parameter from the input config was almost completely ignored. Now it is used to filter out data by adding it to the request params

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesloft labels Mar 7, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 7, 2023

/test connector=connectors/source-salesloft

🕑 connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4355962065
✅ connectors/source-salesloft https://github.com/airbytehq/airbyte/actions/runs/4355962065
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_salesloft/__init__.py       2      0   100%
source_salesloft/source.py       168     36    79%
--------------------------------------------------
TOTAL                            170     36    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================= 35 passed, 2 skipped, 37 warnings in 48.85s ==================

@davydov-d davydov-d marked this pull request as ready for review March 7, 2023 15:49
@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 7, 2023

/publish connector=connectors/source-salesloft

🕑 Publishing the following connectors:
connectors/source-salesloft
https://github.com/airbytehq/airbyte/actions/runs/4356988900


Connector Did it publish? Were definitions generated?
connectors/source-salesloft

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit 9b400a5 into master Mar 7, 2023
@davydov-d davydov-d deleted the ddavydov/#13659-source-salesloft-do-not-ignore-start-date branch March 7, 2023 18:18
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
* airbytehq#13659 source Salesloft: use start_date to filter data

* airbytehq#13659 source salesloft: upd changelog

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesloft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants