New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Sendgrid: new stream Unsubscribe Groups #23959
Source Sendgrid: new stream Unsubscribe Groups #23959
Conversation
@marcosmarxm @sajarin Are you able to help here, please? |
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
@haithem-souala please fix unit tests. I don't have permissions to make changes to your branch. |
airbyte-integrations/connectors/source-sendgrid/source_sendgrid/streams.py
Show resolved
Hide resolved
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
@haithem-souala please check failing tests. |
Done! |
/test connector=connectors/source-sendgrid |
Hey thanks for the contribution and apologies for the delay! I'll be the DRI responsible for reviewing this and getting it across the finish line. We currently have a backlog of about a dozen PRs, but just wanted to let you know that this PR has been added to the queue and I'll be trying my best to get to this as soon as possible. Thanks for the contribution and for being patient :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haithem-souala left some comments, can you rebase on master and bump the metadata.yaml file for the connector as well? Thanks for the contribution and apologies for the delay!
airbyte-integrations/connectors/source-sendgrid/source_sendgrid/schemas/unsubscribe_groups.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-sendgrid/source_sendgrid/schemas/unsubscribe_groups.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @haithem-souala I'll publish the code in another branch because our bot doesn't have access to your branch.
Merged on #26314 |
The current code removes the Messages stream, which is the most important aspect of this connector for us, so we are stuck on 0.3.0, and cannot upgrade for the new functionality. Is there any intent to add this back in to the connector? |
What
Closes #17460
How
Describe the solution
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes