Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Sendgrid: new stream Unsubscribe Groups #23959

Closed
wants to merge 5 commits into from
Closed

Source Sendgrid: new stream Unsubscribe Groups #23959

wants to merge 5 commits into from

Conversation

haithem-souala
Copy link
Contributor

What

Closes #17460

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 11, 2023
@YowanR
Copy link
Contributor

YowanR commented Mar 15, 2023

@marcosmarxm @sajarin Are you able to help here, please?

@marcosmarxm
Copy link
Member

marcosmarxm commented Mar 15, 2023

/test connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/4426005993
❌ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/4426005993
🐛 https://gradle.com/s/6bgngtdmx2ogw

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/unit_test.py::test_streams - assert 15 == 14
	 �[31m================== �[31m�[1m1 failed�[0m, �[32m26 passed�[0m, �[33m87 warnings�[0m�[31m in 2.34s�[0m�[31m ===================�[0m

@marcosmarxm
Copy link
Member

@haithem-souala please fix unit tests. I don't have permissions to make changes to your branch.

@marcosmarxm
Copy link
Member

marcosmarxm commented Mar 15, 2023

/test connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/4426961678
❌ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/4426961678
🐛 https://gradle.com/s/xn44eu2g5hfos

Build Failed

Test summary info:

Could not find result summary

@marcosmarxm
Copy link
Member

@haithem-souala please check failing tests.

@haithem-souala
Copy link
Contributor Author

@haithem-souala please check failing tests.

Done!

@marcosmarxm
Copy link
Member

/test connector=connectors/source-sendgrid

@marcosmarxm marcosmarxm added the contributor-program PRs submitted through the contributor program. label Apr 3, 2023
@sajarin
Copy link
Contributor

sajarin commented Apr 5, 2023

Hey thanks for the contribution and apologies for the delay!

I'll be the DRI responsible for reviewing this and getting it across the finish line. We currently have a backlog of about a dozen PRs, but just wanted to let you know that this PR has been added to the queue and I'll be trying my best to get to this as soon as possible.

Thanks for the contribution and for being patient :)

Copy link
Contributor

@sajarin sajarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haithem-souala left some comments, can you rebase on master and bump the metadata.yaml file for the connector as well? Thanks for the contribution and apologies for the delay!

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @haithem-souala I'll publish the code in another branch because our bot doesn't have access to your branch.

@marcosmarxm
Copy link
Member

Merged on #26314

@marcosmarxm marcosmarxm deleted the connector/source-sendgrid branch May 23, 2023 13:03
@salja03-t21
Copy link

The current code removes the Messages stream, which is the most important aspect of this connector for us, so we are stuck on 0.3.0, and cannot upgrade for the new functionality. Is there any intent to add this back in to the connector?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/sendgrid contributor-program PRs submitted through the contributor program.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Source Sendgrid: new stream Unsubscribe Groups
6 participants