Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-instagram] bump version to 1.0.2 (no changes) #24042

Merged
merged 5 commits into from
Mar 14, 2023

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Mar 14, 2023

Actual changes in this pr

Bumps version to 1.0.2 since the image was already published when we decided we didn't want that version to ever see cloud. We determined that the failures were likely transient, and therefore did not want to mask them. The 1.0.2 tag was manually updated to be a copy of 1.0.1 tag.

The below changes were reverted and never merged / the published version was overridden

What

How

If the previous record doesn't have a date param, use _start_date instead of previous record's date for getting the latest cursor value for updated state

🚨 User Impact 🚨

Failed syncs will succeed, but will temporarily act as full refresh if they don't have a date field.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Mar 14, 2023
@erohmensing
Copy link
Contributor Author

erohmensing commented Mar 14, 2023

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4412409402
❌ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4412409402
🐛 https://gradle.com/s/ghyz6fxa7i2qw

Build Failed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 34 passed, 3 skipped in 175.99s (0:02:55) ===================
	 =========================== short test summary info ============================
	 FAILED integration_tests/test_streams.py::TestInstagramSource::test_incremental_streams
	 �[31m======================== �[31m�[1m1 failed�[0m, �[33m2 warnings�[0m�[31m in 29.42s�[0m�[31m ========================�[0m

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 14, 2023
@erohmensing
Copy link
Contributor Author

erohmensing commented Mar 14, 2023

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4412680952
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/4412680952
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/source.py        31      0   100%
source_instagram/__init__.py       2      0   100%
source_instagram/common.py        36      3    92%
source_instagram/streams.py      205     20    90%
source_instagram/api.py           59      7    88%
--------------------------------------------------
TOTAL                            333     30    91%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_instagram/__init__.py       2      0   100%
source_instagram/api.py           59      5    92%
source_instagram/source.py        31     11    65%
source_instagram/streams.py      205     94    54%
source_instagram/common.py        36     22    39%
--------------------------------------------------
TOTAL                            333    132    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:212: Skipping new incremental test based on acceptance-test-config.yml
================== 34 passed, 3 skipped in 172.98s (0:02:52) ===================

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine as an emergency fix. @davydov-d could you or someone from the team take the action item to figure out the correct long-term fix?

@erohmensing
Copy link
Contributor Author

erohmensing commented Mar 14, 2023

/publish connector=connectors/source-instagram

🕑 Publishing the following connectors:
connectors/source-instagram
https://github.com/airbytehq/airbyte/actions/runs/4412862247


Connector Did it publish? Were definitions generated?
connectors/source-instagram

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@erohmensing erohmensing marked this pull request as ready for review March 14, 2023 06:32
@erohmensing erohmensing enabled auto-merge (squash) March 14, 2023 06:46
@erohmensing erohmensing enabled auto-merge (squash) March 14, 2023 07:55
@erohmensing erohmensing changed the title [source-instagram] fall back to start date if date cursor not available [source-instagram] bump version to 1.0.2 (no changes) Mar 14, 2023
@erohmensing erohmensing merged commit 09593d9 into master Mar 14, 2023
@erohmensing erohmensing deleted the ella/insta-date-cursor branch March 14, 2023 08:20
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
…le (airbytehq#24042)

* Cherry-pick instagram fix

* Bump version

* .parse takes string arguments

* auto-bump connector version

* revert changes, dummy changelog entry

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing added a commit that referenced this pull request Mar 22, 2023
…le (#24042)

* Cherry-pick instagram fix

* Bump version

* .parse takes string arguments

* auto-bump connector version

* revert changes, dummy changelog entry

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing added a commit that referenced this pull request Mar 22, 2023
…le (#24042)

* Cherry-pick instagram fix

* Bump version

* .parse takes string arguments

* auto-bump connector version

* revert changes, dummy changelog entry

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants