Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Trello: Enable in Cloud #24045

Merged
merged 10 commits into from
Mar 15, 2023
Merged

Source Trello: Enable in Cloud #24045

merged 10 commits into from
Mar 15, 2023

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Mar 14, 2023

What

Issue: #23667

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr changed the title Source Xero: Enable in Cloud Source Trello: Enable in Cloud Mar 14, 2023
@grubberr
Copy link
Contributor Author

grubberr commented Mar 14, 2023

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4413207344
❌ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4413207344
🐛 https://gradle.com/s/wyynt5wgpxz2y

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - co...
================== 1 failed, 36 passed, 37 warnings in 57.45s ==================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 14, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Mar 14, 2023

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4413503116
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4413503116
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_trello/__init__.py       2      0   100%
source_trello/utils.py         28      1    96%
source_trello/source.py       113     26    77%
-----------------------------------------------
TOTAL                         143     27    81%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.6.
=================== 36 passed, 1 skipped in 63.74s (0:01:03) ===================

@grubberr
Copy link
Contributor Author

grubberr commented Mar 15, 2023

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4425798055
❌ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4425798055
🐛 https://gradle.com/s/mcvtmiuvqybzu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 22 passed, 13 errors in 36.18s ===================

@grubberr
Copy link
Contributor Author

grubberr commented Mar 15, 2023

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4425913853
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4425913853
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_trello/__init__.py       2      0   100%
source_trello/utils.py         28      1    96%
source_trello/source.py       103     25    76%
-----------------------------------------------
TOTAL                         133     26    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:518: Backward compatibility tests are disabled for version 0.1.6.
======================== 36 passed, 1 skipped in 52.47s ========================

@grubberr
Copy link
Contributor Author

grubberr commented Mar 15, 2023

/publish connector=connectors/source-trello

🕑 Publishing the following connectors:
connectors/source-trello
https://github.com/airbytehq/airbyte/actions/runs/4426295416


Connector Did it publish? Were definitions generated?
connectors/source-trello

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr grubberr merged commit a2c29e0 into master Mar 15, 2023
@grubberr grubberr deleted the grubberr/23667-source-trello-2 branch March 15, 2023 13:45
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/trello
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants