Surface latest sync status for connections. #2405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This solves #2332.
TLDR: Right now there is no summary of a connector's health - the status of a connection's last sync - within the webapp. This change surfaces this information so the UI can take advantage of it.
How
latestSyncJobStatus
field to theWbConnectionRead
struct. Take the chance to rename thelastSync
field tolatestSyncJobCreatedAt
to better reflect what the field captures.lastSync
was confusing as I expect it to return the Id/object of the last sync and not the last sync's timestamp.Since the 'latest' sync job is determined by the
JobHistoryHandler
, I buffed up the job history handler test cases to make sure we do always return the latest sync job.Some minor refactors as I made changes.
Pre-merge Checklist
Recommended reading order