Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Airtable: update spec and doc #24093

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Source Airtable: update spec and doc #24093

merged 4 commits into from
Mar 15, 2023

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/1651

How

Update spec.json and docs to state that the key should be Personal Access Token, not an API Key

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 15, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 15, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-airtable

🕑 connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/4427939762
❌ connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/4427939762
🐛 https://gradle.com/s/25rmtxxqhm7ne

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs2] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs1] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs1] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs1]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs1] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contain...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
======= 2 failed, 36 passed, 1 skipped, 101 warnings, 9 errors in 59.73s =======

> Task :airbyte-integrations:connectors:source-airtable:connectorAcceptanceTest FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings
27 actionable tasks: 9 executed, 18 up-to-date

Publishing build scan...
https://gradle.com/s/25rmtxxqhm7ne

S3 cache writes: 1, elapsed: 620ms, sent to cache: 445 B

@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 15, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-airtable

🕑 connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/4428256038
❌ connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/4428256038
🐛 https://gradle.com/s/ucm5ztnmqwpuy

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs2] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs1] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs1] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs1]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs1] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contain...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
== 2 failed, 36 passed, 1 skipped, 101 warnings, 9 errors in 61.93s (0:01:01) ==

> Task :airbyte-integrations:connectors:source-airtable:connectorAcceptanceTest FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings
27 actionable tasks: 9 executed, 18 up-to-date

Publishing build scan...
https://gradle.com/s/ucm5ztnmqwpuy

S3 cache writes: 1, elapsed: 628ms, sent to cache: 448 B

@bnchrch bnchrch requested review from bnchrch and removed request for erohmensing March 15, 2023 16:14
erohmensing
erohmensing reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look, but will wait until tests are passing to approve in case code changes. Also will pull in @bnchrch as he's coming on call

airbyte-integrations/connectors/source-airtable/source_airtable/spec.json Show resolved Hide resolved
@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 15, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-airtable

🕑 connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/4428749885
✅ connectors/source-airtable https://github.com/airbytehq/airbyte/actions/runs/4428749885
Python tests coverage:

Name                                Stmts   Miss  Cover
-------------------------------------------------------
source_airtable/__init__.py             2      0   100%
source_airtable/streams.py             92      1    99%
source_airtable/source.py              38      1    97%
source_airtable/schema_helpers.py      48      9    81%
source_airtable/auth.py                21     10    52%
-------------------------------------------------------
TOTAL                                 201     21    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: Incremental syncs are not supported on this connector.
=========== 47 passed, 1 skipped, 101 warnings in 152.45s (0:02:32) ============

@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 15, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-airtable

🕑 Publishing the following connectors:
connectors/source-airtable
https://github.com/airbytehq/airbyte/actions/runs/4429388637


Connector Did it publish? Were definitions generated?
connectors/source-airtable ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit 3a63e66 into master Mar 15, 2023
@davydov-d davydov-d deleted the ddavydov/#1651-source-airtable-update-spec-and-doc branch March 15, 2023 19:19
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
@davydov-d @octavia-squidington-iii @adriennevermorel
Source Airtable: update spec and doc (airbytehq#24093)
3ab3eb9 
* #1651 source airtable: update spec and doc

* #1651 source airtable: upd changelog

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
@davydov-d @octavia-squidington-iii @erohmensing
Source Airtable: update spec and doc (#24093)
190bc03 
* #1651 source airtable: update spec and doc

* #1651 source airtable: upd changelog

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
@davydov-d @octavia-squidington-iii @erohmensing
Source Airtable: update spec and doc (#24093)
18841a1 
* #1651 source airtable: update spec and doc

* #1651 source airtable: upd changelog

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

@bnchrch bnchrch Awaiting requested review from bnchrch

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/airtable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davydov-d @erohmensing @octavia-squidington-iii