Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Xero: Certify to Beta #24217

Merged
merged 14 commits into from Mar 20, 2023
Merged

Source Xero: Certify to Beta #24217

merged 14 commits into from Mar 20, 2023

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Mar 18, 2023

What

Issue: #23616

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)

  • Secrets in the connector's spec are annotated with airbyte_secret

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

  • Code reviews completed

  • Connector version has been incremented

  • Documentation updated

    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr linked an issue Mar 19, 2023 that may be closed by this pull request
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 19, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Mar 20, 2023

/test connector=connectors/source-xero

🕑 connectors/source-xero https://github.com/airbytehq/airbyte/actions/runs/4467499963
❌ connectors/source-xero https://github.com/airbytehq/airbyte/actions/runs/4467499963
🐛 https://gradle.com/s/krhv3b2deisnk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_config_match_spec[inputs0] - Failed: Conf...
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 3 failed, 21 passed, 13 errors in 45.63s ===================

@grubberr grubberr requested a review from lazebnyi March 20, 2023 11:30
@grubberr
Copy link
Contributor Author

grubberr commented Mar 20, 2023

/test connector=connectors/source-xero

🕑 connectors/source-xero https://github.com/airbytehq/airbyte/actions/runs/4470320461
❌ connectors/source-xero https://github.com/airbytehq/airbyte/actions/runs/4470320461
🐛 https://gradle.com/s/3suwsevn7y4ls

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestBasicRead::test_read[inputs0] - FileNotFoundError: [E...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
============== 35 passed, 1 skipped, 1 error in 593.03s (0:09:53) ==============

@grubberr
Copy link
Contributor Author

grubberr commented Mar 20, 2023

/test connector=connectors/source-xero

🕑 connectors/source-xero https://github.com/airbytehq/airbyte/actions/runs/4470885687
✅ connectors/source-xero https://github.com/airbytehq/airbyte/actions/runs/4470885687
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_xero/source.py        25      0   100%
source_xero/__init__.py       2      0   100%
source_xero/streams.py      159      8    95%
source_xero/oauth.py         28     15    46%
---------------------------------------------
TOTAL                       214     23    89%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 36 passed, 1 skipped in 605.71s (0:10:05) ===================

@grubberr
Copy link
Contributor Author

grubberr commented Mar 20, 2023

/publish connector=connectors/source-xero

🕑 Publishing the following connectors:
connectors/source-xero
https://github.com/airbytehq/airbyte/actions/runs/4471206757


Connector Did it publish? Were definitions generated?
connectors/source-xero

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr grubberr merged commit b588a52 into master Mar 20, 2023
20 checks passed
@grubberr grubberr deleted the grubberr/23616-source-xero branch March 20, 2023 19:28
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/xero
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Xero: Certify to Beta
3 participants