Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Bind Ads: add campaignlabels col #24223

Merged
merged 10 commits into from
May 9, 2023
Merged

🎉 Source Bind Ads: add campaignlabels col #24223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e52452c
campaignLabels col
trowacat Mar 19, 2023
2b05771
Merge branch 'source-bing-ads-add-campaignlabels-col' of https://gith…
trowacat Mar 19, 2023
95d7938
update pr number
trowacat Mar 19, 2023
2f6340f
Merge branch 'master' into source-bing-ads-add-campaignlabels-col
sajarin Apr 7, 2023
06e2c35
updated expected_records.txt with campaign labels in campaign perform…
sajarin Apr 10, 2023
e7c918c
Merge branch 'master' into source-bing-ads-add-campaignlabels-col
sajarin Apr 10, 2023
e45f344
solve conflict
marcosmarxm May 8, 2023
1e85516
fix expected records
marcosmarxm May 8, 2023
5f1709e
bump metadata version
marcosmarxm May 8, 2023
953ab9e
auto-bump connector version
octavia-squidington-iii May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config-oss/init-oss/src/main/resources/seed/oss_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9985,7 +9985,7 @@
"sourceDefinitionId": "47f25999-dd5e-4636-8c39-e7cea2453331",
"name": "Bing Ads",
"dockerRepository": "airbyte/source-bing-ads",
"dockerImageTag": "0.1.21",
"dockerImageTag": "0.1.22",
"documentationUrl": "https://docs.airbyte.com/integrations/sources/bing-ads",
"icon": "bingads.svg",
"sourceType": "api",
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@
- name: Bing Ads
sourceDefinitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerRepository: airbyte/source-bing-ads
dockerImageTag: 0.1.21
dockerImageTag: 0.1.22
documentationUrl: https://docs.airbyte.com/integrations/sources/bing-ads
icon: bingads.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config-oss/init-oss/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2042,7 +2042,7 @@
- "overwrite"
- "append"
- "append_dedup"
- dockerImage: "airbyte/source-bing-ads:0.1.21"
- dockerImage: "airbyte/source-bing-ads:0.1.22"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/bing-ads"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-bing-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.21
LABEL io.airbyte.version=0.1.22
LABEL io.airbyte.name=airbyte/source-bing-ads
8 changes: 4 additions & 4 deletions airbyte-integrations/connectors/source-bing-ads/integration_tests/expected_records.txt
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-bing-ads/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerImageTag: 0.1.21
dockerImageTag: 0.1.22
dockerRepository: airbyte/source-bing-ads
githubIssueLabel: source-bing-ads
icon: bingads.svg
Expand Down
3 changes: 3 additions & 0 deletions ...tions/connectors/source-bing-ads/source_bing_ads/schemas/campaign_performance_report.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@
"CampaignStatus": {
"type": ["null", "string"]
},
"CampaignLabels": {
"type": ["null", "string"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please confirm that CampaignLabels is just a string, because name assumes that there are a lot of labels (probably list of strings? )

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trowacat can you confirm the above, please? thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From: https://learn.microsoft.com/en-us/advertising/reporting-service/campaignperformancereportcolumn?view=bingads-13#campaignlabels

CampaignLabels
The labels applied to the campaign.Labels are delimited by a semicolon (;) in the report download.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trowacat did you have time to take a look on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@midavadim I added some labels to our integration account data
image
The data field is correct.

},
"Impressions": {
"type": ["null", "integer"]
},
Expand Down
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-bing-ads/source_bing_ads/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@ class CampaignPerformanceReport(PerformanceReportsMixin, BingAdsStream):
"CampaignName",
"CampaignType",
"CampaignStatus",
"CampaignLabels",
"Impressions",
"Clicks",
"Ctr",
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/bing-ads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ The Bing Ads API limits the number of requests for all Microsoft Advertising cli
## Changelog
| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------------------------------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------|
| 0.1.22 | 2023-05-08 | [24223](https://github.com/airbytehq/airbyte/pull/24223) | Add CampaignLabels report column in campaign performance report |
| 0.1.21 | 2023-04-28 | [25668](https://github.com/airbytehq/airbyte/pull/25668) | Add undeclared fields to accounts, campaigns, campaign_performance_report, keyword_performance_report and account_performance_report streams |
| 0.1.20 | 2023-03-09 | [23663](https://github.com/airbytehq/airbyte/pull/23663) | Add lookback window for performance reports in incremental mode |
| 0.1.19 | 2023-03-08 | [23868](https://github.com/airbytehq/airbyte/pull/23868) | Add dimensional-type columns for reports. |
Expand Down