Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Trello: get board ids also from organizations #24266

Merged
merged 6 commits into from
Mar 21, 2023

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Mar 21, 2023

What

Issue: #12695

  • new stream added Organizations
  • now get list of boards from 2 endpoints:
    • /members/me/boards
    • /members/me/organizations
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)

  • Secrets in the connector's spec are annotated with airbyte_secret

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

  • Code reviews completed

  • Connector version has been incremented

  • Documentation updated

    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 21, 2023
@grubberr
Copy link
Contributor Author

grubberr commented Mar 21, 2023

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4476439098
❌ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4476439098
🐛 https://gradle.com/s/izlhx2b23dol2

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream actio...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
============== 1 failed, 35 passed, 1 skipped in 61.75s (0:01:01) ==============

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr changed the title Source Trello: BoardsOrganizations Source Trello: get board ids also from organizations Mar 21, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Mar 21, 2023

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4477869396
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/4477869396
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_trello/auth.py          11      0   100%
source_trello/__init__.py       2      0   100%
source_trello/utils.py         47      1    98%
source_trello/source.py       114     14    88%
-----------------------------------------------
TOTAL                         174     15    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
=================== 36 passed, 1 skipped in 61.53s (0:01:01) ===================

@grubberr
Copy link
Contributor Author

grubberr commented Mar 21, 2023

/publish connector=connectors/source-trello

🕑 Publishing the following connectors:
connectors/source-trello
https://github.com/airbytehq/airbyte/actions/runs/4479782040


Connector Did it publish? Were definitions generated?
connectors/source-trello

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr grubberr merged commit 0409574 into master Mar 21, 2023
@grubberr grubberr deleted the grubberr/12695-source-trello branch March 21, 2023 14:26
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/trello
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants