Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source linkedin-pages: remove authSpec #24352

Merged

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/1692

How

Remove authSpecification from spec.json, as Oauth flow is not yet implemented for this connector, so the "Authenticate" button should not show up in cloud

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-pages labels Mar 22, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 22, 2023

/test connector=connectors/source-linkedin-pages

🕑 connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/4487805368
✅ connectors/source-linkedin-pages https://github.com/airbytehq/airbyte/actions/runs/4487805368
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
======================== 33 passed, 2 skipped in 41.05s ========================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 22, 2023

/publish connector=connectors/source-linkedin-pages

🕑 Publishing the following connectors:
connectors/source-linkedin-pages
https://github.com/airbytehq/airbyte/actions/runs/4487964845


Connector Did it publish? Were definitions generated?
connectors/source-linkedin-pages

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit d039c93 into master Mar 22, 2023
17 of 18 checks passed
@davydov-d davydov-d deleted the ddavydov/#1692-source-linkedin-pages-disable-auth-button branch March 22, 2023 09:22
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* #1692 source linkedin-pages remove authSpec

* #1692 source linkedin-pages: upd changelog

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* #1692 source linkedin-pages remove authSpec

* #1692 source linkedin-pages: upd changelog

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants