Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source strava: update docs + http -> https #24368

Merged
merged 11 commits into from
Mar 23, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Mar 22, 2023

What

update docs; add date-time format

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)

  • Secrets in the connector's spec are annotated with airbyte_secret

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

  • Code reviews completed

  • Connector version has been incremented

  • Documentation updated

    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/strava labels Mar 22, 2023
@lazebnyi lazebnyi changed the title Source strava: update docs + https -> https Source strava: update docs + http -> https Mar 23, 2023
@artem1205
Copy link
Collaborator Author

artem1205 commented Mar 23, 2023

/test connector=connectors/source-strava

🕑 connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/4503671343
✅ connectors/source-strava https://github.com/airbytehq/airbyte/actions/runs/4503671343
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_strava/source.py        18      0   100%
source_strava/__init__.py       2      0   100%
source_strava/streams.py       46      6    87%
-----------------------------------------------
TOTAL                          66      6    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_incremental.py:22: `future_state` has a bypass reason, skipping.
============ 39 passed, 1 skipped, 101 warnings in 62.22s (0:01:02) ============

@artem1205
Copy link
Collaborator Author

artem1205 commented Mar 23, 2023

/publish connector=connectors/source-strava

🕑 Publishing the following connectors:
connectors/source-strava
https://github.com/airbytehq/airbyte/actions/runs/4504068277


Connector Did it publish? Were definitions generated?
connectors/source-strava

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205 artem1205 merged commit c279913 into master Mar 23, 2023
@artem1205 artem1205 deleted the artem1205/source-strava-to-beta branch March 23, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/strava
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants