Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source chargebee: ignore http 404 errors #24370

Merged
merged 4 commits into from Mar 22, 2023

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/1689
Stream customers may return deleted entities whereis contacts substream may get a 404 http error when accessing deleted customer's contacts.

How

Add error handler to contacts stream: ignore 404 errors.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chargebee labels Mar 22, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 22, 2023

/test connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/4493074187
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/4493074187
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_chargebee/components.py       9      0   100%
source_chargebee/__init__.py         2      0   100%
source_chargebee/source.py           4      1    75%
----------------------------------------------------
TOTAL                               15      1    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 1237.12s (0:20:37) ==================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 22, 2023

/publish connector=connectors/source-chargebee

🕑 Publishing the following connectors:
connectors/source-chargebee
https://github.com/airbytehq/airbyte/actions/runs/4493422379


Connector Did it publish? Were definitions generated?
connectors/source-chargebee

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 22, 2023

/publish connector=connectors/source-chargebee

🕑 Publishing the following connectors:
connectors/source-chargebee
https://github.com/airbytehq/airbyte/actions/runs/4493429197


Connector Did it publish? Were definitions generated?
connectors/source-chargebee

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit dd74226 into master Mar 22, 2023
17 of 18 checks passed
@davydov-d davydov-d deleted the ddavydov/#1689-source-chargebee-ignore-404-errors branch March 22, 2023 19:54
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* #1689 source chargebee: ignore http 404 errors

* #1689 source chargebee: upd changelog

* merge two handlers

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* #1689 source chargebee: ignore http 404 errors

* #1689 source chargebee: upd changelog

* merge two handlers

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chargebee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants