Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use config filename instead of absolute path in target factory #245

Merged
merged 3 commits into from
Sep 13, 2020
Merged

use config filename instead of absolute path in target factory #245

merged 3 commits into from
Sep 13, 2020

Conversation

sherifnada
Copy link
Contributor

With this, all e2e tests are passing.

@sherifnada sherifnada requested review from cgardens, michel-tricot and jrhizor and removed request for cgardens September 12, 2020 19:57
@sherifnada sherifnada merged commit 16c61a7 into master Sep 13, 2020
michel-tricot
michel-tricot reviewed Sep 13, 2020
View reviewed changes
Copy link
Contributor

@michel-tricot michel-tricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@sherifnada sherifnada mentioned this pull request Sep 13, 2020
Closed
@sherifnada sherifnada deleted the sherif/add-sync-e2e-test branch September 13, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-tricot michel-tricot michel-tricot left review comments

@cgardens cgardens Awaiting requested review from cgardens

@jrhizor jrhizor Awaiting requested review from jrhizor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sherifnada @michel-tricot