-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Jira: Removed Connector Domain Pattern from Spec #24636
Conversation
The pattern for the JIRA domain will not necessarily end in atlassian.net. (e.g. cloud hosted JIRA can also be jira.com and on premise installations can also deviate from this pattern). I propose removing this restriction. Our opinion is that it's too strict and brings little to no value. This PR fixes: #7502
airbyte-integrations/connectors/source-jira/source_jira/spec.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Willi Müller <willi.mueller@posteo.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to see this on master!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sumegim
/test connector=connectors/source-jira
Build PassedTest summary info:
|
/publish connector=connectors/source-jira
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
The pattern for the JIRA domain will not necessarily end in atlassian.net. (e.g. cloud hosted JIRA can also be jira.com and on premise installations can also deviate from this pattern).
I propose removing this restriction. Our opinion is that it's too strict and brings little to no value.
This PR fixes: #7502
Closes #11414
How
Removed pattern requirement from domain filed in the JIRA connector
🚨 User Impact 🚨
no breaking changes
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with
airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.Code reviews completed
Connector version has been incremented
Dockerfile
has updated versionDocumentation updated
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
with an entry for the new version. See changelog examplePR name follows PR naming conventions