Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Jira: Removed Connector Domain Pattern from Spec #24636

Merged
merged 11 commits into from
Apr 10, 2023
Merged

Source Jira: Removed Connector Domain Pattern from Spec #24636

merged 11 commits into from
Apr 10, 2023

Conversation

sumegim
Copy link
Contributor

@sumegim sumegim commented Mar 28, 2023

What

The pattern for the JIRA domain will not necessarily end in atlassian.net. (e.g. cloud hosted JIRA can also be jira.com and on premise installations can also deviate from this pattern).

I propose removing this restriction. Our opinion is that it's too strict and brings little to no value.

This PR fixes: #7502
Closes #11414

How

Removed pattern requirement from domain filed in the JIRA connector

🚨 User Impact 🚨

no breaking changes

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)

  • Secrets in the connector's spec are annotated with airbyte_secret

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

  • Code reviews completed

  • Connector version has been incremented

  • Documentation updated

    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • PR name follows PR naming conventions

The pattern for the JIRA domain will not necessarily end in atlassian.net. (e.g. cloud hosted JIRA can also be jira.com and on premise installations can also deviate from this pattern). 

I propose removing this restriction. Our opinion is that it's too strict and brings little to no value. 

This PR fixes: #7502
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2023

CLA assistant check
All committers have signed the CLA.

Co-authored-by: Willi Müller <willi.mueller@posteo.de>
Copy link
Contributor

@willi-mueller willi-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see this on master!

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sumegim

@marcosmarxm marcosmarxm changed the title Removing JIRA Connector Domain Pattern Source Jira: Removed Connector Domain Pattern from Spec Apr 10, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 10, 2023
@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 10, 2023

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4659948172
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4659948172
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_jira/utils.py         21      0   100%
source_jira/__init__.py       2      0   100%
source_jira/source.py        47      4    91%
source_jira/streams.py      640     63    90%
---------------------------------------------
TOTAL                       710     67    91%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 39 passed, 1 skipped in 725.27s (0:12:05) ===================

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 10, 2023

/publish connector=connectors/source-jira

🕑 Publishing the following connectors:
connectors/source-jira
https://github.com/airbytehq/airbyte/actions/runs/4660152343


Connector Did it publish? Were definitions generated?
connectors/source-jira

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm merged commit b73d10b into airbytehq:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants