Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Younium: Adding Booking and Account streams #24655

Closed

Conversation

hhagblom
Copy link
Contributor

@hhagblom hhagblom commented Mar 29, 2023

What

We needed to get Booking with Booking lines, which are the transaction level data on an order as well as the Account stream.

This is to fix issue #24654

How

Added the booking and account stream to the existing source connecting

🚨 User Impact 🚨

No breaking changes, when the connector is refreshed the two new streams should appear for syncing.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member

  • Community member? Grant edit access to maintainers (instructions)
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/younium labels Mar 29, 2023
@hhagblom
Copy link
Contributor Author

Younium Sync Airbyte

Screenshot of sucessful syncing of two new streams.

@hhagblom
Copy link
Contributor Author

Younium Connector passing tests

Younium Integration Test Run

Screenshot of passing unit-tests, there seem to be no integration tests running at the moment.

@hhagblom hhagblom force-pushed the feature/younium_booking_accounts branch from c8157ed to 36da3fe Compare May 26, 2023 09:12
@jrolom jrolom removed the bounty label Jun 9, 2023
@marcosmarxm marcosmarxm added team/tse Technical Support Engineers community and removed community-legacy labels Jun 27, 2023
@marcosmarxm
Copy link
Member

Sorry for the long delay in getting this reviewed and merged. Our team is currently finishing the August Hackathon review contributions over the next two weeks, and after that, we will return to the community backlog.

@hhagblom
Copy link
Contributor Author

Thanks for considering it. While you're at it could you reconsider the Fortnox Connector pull request that we supplied or give us a reason why it was closed. It would be a waste to not accept it if there is no good reason for it.

@sajarin
Copy link
Contributor

sajarin commented Sep 27, 2023

hey @hhagblom any chance you could rebase this branch on master, it has been many months (apologies for not getting to this sooner.)

In addition, there are some minor review changes which i'd like to just fix and commit directly to your branch but I don't have push permissions to your branch (likely for a good reason since it's a branch from your company's fork of Airbyte.)

@sajarin
Copy link
Contributor

sajarin commented Oct 4, 2023

hey @hhagblom this has been merged in #31064 (since I couldn't push changes to your branch here)

Thanks for the contribution and apologies for the delay!

@sajarin sajarin closed this Oct 4, 2023
@hhagblom
Copy link
Contributor Author

hey @hhagblom this has been merged in #31064 (since I couldn't push changes to your branch here)

Thanks for the contribution and apologies for the delay!

Ok, sorry about not getting to it and thanks for sorting it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/younium team/tse Technical Support Engineers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants