Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-db-sources: introduce method to set cursor value for TIMESTAMP_WITH_TIMEZONE and TIME_WITH_TIMEZONE #24693

Merged

Conversation

subodh1810
Copy link
Contributor

@subodh1810 subodh1810 commented Mar 30, 2023

In the PR #24667 I changed the implementation to allow TIMESTAMP_WITH_TIMEZONE and TIME_WITH_TIMEZONE to be used as a cursor value but didnt introduce method to set these values in the query
For : #23103

@subodh1810 subodh1810 self-assigned this Mar 30, 2023
@subodh1810
Copy link
Contributor Author

subodh1810 commented Mar 30, 2023

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/4563802238
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/4563802238
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
======================== 34 passed, 3 skipped in 53.57s ========================

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 30, 2023
@subodh1810
Copy link
Contributor Author

/test connector=connectors/source-snowflake

1 similar comment
@subodh1810
Copy link
Contributor Author

/test connector=connectors/source-snowflake

@subodh1810
Copy link
Contributor Author

subodh1810 commented Mar 30, 2023

/publish connector=connectors/source-snowflake

🕑 Publishing the following connectors:
connectors/source-snowflake
https://github.com/airbytehq/airbyte/actions/runs/4565165859


Connector Did it publish? Were definitions generated?
connectors/source-snowflake

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@subodh1810
Copy link
Contributor Author

/approve-and-merge reason="Safe and tested changes"

@octavia-approvington
Copy link
Contributor

What are we doing again?
merge and squash

@octavia-approvington octavia-approvington merged commit ac5b109 into master Mar 30, 2023
15 of 17 checks passed
@octavia-approvington octavia-approvington deleted the snowflake-fix-timestamp-cursor-30th-march branch March 30, 2023 14:06
@github-actions
Copy link
Contributor

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (1)

Connector Version Changelog Publish
source-snowflake 0.1.34
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/snowflake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants