Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source SurveyCTO: Incremental Sync fix #24784

Closed
wants to merge 11 commits into from

Conversation

siddhant3030
Copy link
Contributor

@siddhant3030 siddhant3030 commented Apr 3, 2023

Issue #24830

What

Currently, Incremental sync is not working for this version because of a lot of date format changes in the API.

How

I'm updating the code which removes the format changes in the data and changed the cursor field to get the exact same that we get from the data.

Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@marcosmarxm
Copy link
Member

@siddhant3030 please create an issue and link to your PR. Add logs from the error and any relevant information.

@marcosmarxm
Copy link
Member

Also update the title of your PR to Source Survey CTO: small description of change...

@siddhant3030 siddhant3030 changed the title Feature/survey cto fix Source SurveyCTO: Incremental fix Apr 4, 2023
@siddhant3030 siddhant3030 changed the title Source SurveyCTO: Incremental fix Source SurveyCTO: Incremental Sync fix Apr 4, 2023
@archangelic
Copy link
Contributor

Merged in #25522

@siddhant3030 siddhant3030 deleted the feature/survey_cto_fix branch August 11, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants