New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source hubspot: Add new stream DealsArchived
#24980
Conversation
# Conflicts: # airbyte-integrations/connectors/source-hubspot/integration_tests/expected_records.jsonl
# Conflicts: # airbyte-integrations/connectors/source-hubspot/Dockerfile
# Conflicts: # airbyte-integrations/connectors/source-hubspot/integration_tests/abnormal_state.json # airbyte-integrations/connectors/source-hubspot/source_hubspot/streams.py
…ubspot-19838 # Conflicts: # airbyte-integrations/connectors/source-hubspot/integration_tests/expected_records.jsonl
# Conflicts: # airbyte-integrations/connectors/source-hubspot/Dockerfile # airbyte-integrations/connectors/source-hubspot/integration_tests/expected_records.jsonl # docs/integrations/sources/hubspot.md
/test connector=connectors/source-hubspot
Build FailedTest summary info:
|
/test connector=connectors/source-hubspot
Build FailedTest summary info:
|
/test connector=connectors/source-hubspot
Build FailedTest summary info:
|
/test connector=connectors/source-hubspot
Build PassedTest summary info:
|
/publish connector=connectors/source-hubspot
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Resolve #19838
How
add new stream for archived deals.
ClientSideIncrementalStream used as a base to bypass Hubspot api limitation on CRM
search
endpoint: 400 error is raised ifarchivedAt
field used as a filter.Recommended reading order
y.python
🚨 User Impact 🚨
no breaking changes
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with
airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.Code reviews completed
Connector version has been incremented
Dockerfile
has updated versionDocumentation updated
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
with an entry for the new version. See changelog examplePR name follows PR naming conventions
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here