Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Recharge: Add slicing to fetch data with chunks #24990

Merged
merged 6 commits into from Apr 7, 2023

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Apr 7, 2023

What

https://github.com/airbytehq/oncall/issues/1737 - fix
Provider return 504 error when request to large data

How

Add slicing to fetch data with chunks.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)

  • Secrets in the connector's spec are annotated with airbyte_secret

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

  • Code reviews completed

  • Connector version has been incremented

  • Documentation updated

    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@lazebnyi lazebnyi requested a review from artem1205 April 7, 2023 17:05
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/recharge labels Apr 7, 2023
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Apr 7, 2023

/test connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/4640320985

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Apr 7, 2023

/test connector=connectors/source-recharge

🕑 connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/4640802740
✅ connectors/source-recharge https://github.com/airbytehq/airbyte/actions/runs/4640802740
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_recharge/source.py        23      0   100%
source_recharge/__init__.py       2      0   100%
source_recharge/api.py           82     11    87%
-------------------------------------------------
TOTAL                           107     11    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 38 passed, 2 skipped in 334.92s (0:05:34) ===================

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Apr 7, 2023

/publish connector=connectors/source-recharge

🕑 Publishing the following connectors:
connectors/source-recharge
https://github.com/airbytehq/airbyte/actions/runs/4640878643


Connector Did it publish? Were definitions generated?
connectors/source-recharge

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lazebnyi lazebnyi enabled auto-merge (squash) April 7, 2023 20:11
@lazebnyi lazebnyi merged commit 5d6867d into master Apr 7, 2023
21 of 25 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/1737-recharge-add-slicing branch April 7, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/recharge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants